Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake patches patched_asiolist.cpp ASIO SDK file in tree #1004

Open
RossBencina opened this issue Feb 6, 2025 · 1 comment
Open

cmake patches patched_asiolist.cpp ASIO SDK file in tree #1004

RossBencina opened this issue Feb 6, 2025 · 1 comment
Labels
build-cmake CMake build system

Comments

@RossBencina
Copy link
Collaborator

#997 patches the ASIO SDK by placing a new patched_asiolist.cpp file inside the user's ASIO SDK directory. Modifying the user's file system is not ideal. The patched file should be placed in a temporary location.
@RossBencina RossBencina added the build-cmake CMake build system label Feb 6, 2025
@RossBencina RossBencina mentioned this issue Feb 6, 2025
Merged
RossBencina pushed a commit that referenced this issue Feb 6, 2025
@sonoro1234
cmake: patch asiolist.cpp into patched_asiolist.cpp as issue #331 exp…
e4fdd66 
…lains, see also #1004 (#997)
@sonoro1234
Copy link
Contributor

sonoro1234 commented Feb 7, 2025 •
edited
Loading

ASIO SDK directory is downloaded in the build process inside the cmake build directory so that it is a temporary location?

Unless the old method of having asiosdk in the source dir is used. But then at least leaves original asiolist.cpp untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-cmake CMake build system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sonoro1234 @RossBencina