Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test xt/author/stdin.t fails in github workflows #125

Open
happy-barney opened this issue Dec 26, 2023 · 2 comments
Open

test xt/author/stdin.t fails in github workflows #125

happy-barney opened this issue Dec 26, 2023 · 2 comments

Comments

@happy-barney
Copy link

test simply checks whether STDIN is a tty.

Such test doesn't check anything and should be removed.
@Leont
Copy link
Member

Leont commented Dec 27, 2023

Possibly so, but why would you run author tests in github workflows?

@happy-barney
Copy link
Author

current workflow has AUTHOR_TESTING env variable set to 1 (luckily it is not used as far as it is not propagated into container)

on other hand, pod tests shuld be imho executed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Leont @happy-barney