Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Windows installation dir name change Pivx --> PIVX #1215

Closed

Conversation

random-zebra
Copy link

Closes #1212

@random-zebra random-zebra added Build System Windows Issues/problems specifically related to Windows Trivial extremely simple issues labels Dec 19, 2019
@random-zebra random-zebra added this to the 4.1.0 milestone Dec 19, 2019
@random-zebra random-zebra self-assigned this Dec 19, 2019
@furszy
Copy link

furszy commented Dec 19, 2019

This will create a new folder and not update the previous binary. Shouldn't us notifícate the user in some way or remove the /Pivx folder automatically?

@random-zebra
Copy link
Author

The old uninstaller should remove the binary from the old folder.

@Fuzzbawls
Copy link
Collaborator

the old uninstaller will certainly remove the old binary and installation dir...however, the running of the old uninstaller would need to be done manually prior to running the new installer with this change as-is.

I believe there is a way to script the running of an old/existing uninstaller prior to continuing with a new install, but haven't really looked into it.

@random-zebra random-zebra modified the milestones: 4.1.0, Future Mar 30, 2020
@random-zebra random-zebra modified the milestones: Future, 5.0.0 Apr 24, 2020
@furszy furszy modified the milestones: 4.2.0, Future Jul 1, 2020
@random-zebra random-zebra deleted the 2019_windows_installdir branch September 24, 2020 00:26
@random-zebra random-zebra removed this from the Future milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System Trivial extremely simple issues Windows Issues/problems specifically related to Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Trivial] Create PIVX folder instead of Pivx when installing a new wallet
3 participants