From f317b40789479b892a04654d1ef888134f27ac29 Mon Sep 17 00:00:00 2001 From: YvetteNikolov Date: Mon, 19 Aug 2024 09:56:09 +0200 Subject: [PATCH] (chore): js formatting --- CHANGELOG.md | 6 ++ js/limit-group-connections.js | 111 +++++++++----------- js/limit-item-connections.js | 168 ++++++++++++++----------------- js/limit-subtheme-connections.js | 92 ++++++++--------- pdc-base.php | 2 +- src/Base/Foundation/Plugin.php | 2 +- 6 files changed, 174 insertions(+), 207 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a08b125..8ae2f61 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # CHANGELOG +## Version [3.12.2] (2024-08-19) + +### Feat + +- Refractor the validation JavaScript of the post 2 post connections. + ## Version [3.12.1] (2024-06-20) ### Feat diff --git a/js/limit-group-connections.js b/js/limit-group-connections.js index 8244d7a..568954d 100644 --- a/js/limit-group-connections.js +++ b/js/limit-group-connections.js @@ -1,81 +1,68 @@ -document.addEventListener('DOMContentLoaded', () => { - const selectors = { - groupCategoryMetaboxWrapper: '#p2p-to-pdc-category_to_pdc-group', - groupSubcategoryMetaboxWrapper: '#p2p-to-pdc-subcategory_to_pdc-group', +document.addEventListener( 'DOMContentLoaded', () => { + const groupCategoryMetaboxWrapper = '#p2p-to-pdc-category_to_pdc-group'; + const groupSubcategoryMetaboxWrapper = '#p2p-to-pdc-subcategory_to_pdc-group'; - groupCategoryMetabox: 'div[data-p2p_type="pdc-category_to_pdc-group"]', - groupSubcategoryMetabox: 'div[data-p2p_type="pdc-subcategory_to_pdc-group"]', + const groupCategoryMetabox = 'div[data-p2p_type="pdc-category_to_pdc-group"]'; + const groupSubcategoryMetabox = 'div[data-p2p_type="pdc-subcategory_to_pdc-group"]'; - groupCategoryConnectionTableRow: 'div[data-p2p_type="pdc-category_to_pdc-group"] > table.p2p-connections > tbody > tr', - groupSubcategoryConnectionTableRow: 'div[data-p2p_type="pdc-subcategory_to_pdc-group"] > table.p2p-connections > tbody > tr', + const groupCategoryConnectionTableRow = 'div[data-p2p_type="pdc-category_to_pdc-group"] > table.p2p-connections > tbody > tr'; + const groupSubcategoryConnectionTableRow = 'div[data-p2p_type="pdc-subcategory_to_pdc-group"] > table.p2p-connections > tbody > tr'; - postPublishButton: 'div.edit-post-header__settings > button.editor-post-publish-button__button', - }; + const postPublishButton = 'div.edit-post-header__settings > button.editor-post-publish-button__button'; - const { - groupCategoryMetaboxWrapper, - groupSubcategoryMetaboxWrapper, - groupCategoryMetabox, - groupSubcategoryMetabox, - groupCategoryConnectionTableRow, - groupSubcategoryConnectionTableRow, - postPublishButton, - } = selectors; + // Monitor changes to metaboxes + observeMetaboxChanges( groupCategoryMetabox, groupCategoryMetaboxWrapper, groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton ); + observeMetaboxChanges( groupSubcategoryMetabox, groupSubcategoryMetaboxWrapper, groupSubcategoryConnectionTableRow, groupCategoryConnectionTableRow, postPublishButton ); - // Monitor changes to metaboxes - observeMetaboxChanges(groupCategoryMetabox, groupCategoryMetaboxWrapper, groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton); - observeMetaboxChanges(groupSubcategoryMetabox, groupSubcategoryMetaboxWrapper, groupSubcategoryConnectionTableRow, groupCategoryConnectionTableRow, postPublishButton); - - // Validate connections on page load - validateConnectionsOnLoad({ + // Validate connections on page load + validateConnectionsOnLoad( { groupCategoryMetaboxWrapper, - groupSubcategoryMetaboxWrapper, - groupCategoryConnectionTableRow, - groupSubcategoryConnectionTableRow, - postPublishButton, - }); -}); - -function observeMetaboxChanges(metabox, metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton) { - const observer = new MutationObserver(() => { - validateConnectionState({ metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton }); - }); - - const targetNode = document.querySelector(metabox); - if (targetNode) { - observer.observe(targetNode, { childList: true, subtree: true }); - } + groupSubcategoryMetaboxWrapper, + groupCategoryConnectionTableRow, + groupSubcategoryConnectionTableRow, + postPublishButton, + } ); +} ); + +function observeMetaboxChanges( metabox, metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton ) { + const observer = new MutationObserver( () => { + validateConnectionState( { metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton } ); + } ); + + const targetNode = document.querySelector( metabox ); + if ( targetNode ) { + observer.observe( targetNode, { childList: true, subtree: true } ); + } } -function validateConnectionsOnLoad({ groupCategoryMetaboxWrapper, groupSubcategoryMetaboxWrapper, groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton }) { - setTimeout(() => { - validateConnectionState({ metaboxWrapper: groupCategoryMetaboxWrapper, mainConnectionTableRow: groupCategoryConnectionTableRow }); - validateConnectionState({ metaboxWrapper: groupSubcategoryMetaboxWrapper, mainConnectionTableRow: groupSubcategoryConnectionTableRow }); - validatePublishButtonState({ groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton }); - }, 1000); +function validateConnectionsOnLoad( { groupCategoryMetaboxWrapper, groupSubcategoryMetaboxWrapper, groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton } ) { + setTimeout( () => { + validateConnectionState( { metaboxWrapper: groupCategoryMetaboxWrapper, mainConnectionTableRow: groupCategoryConnectionTableRow } ); + validateConnectionState( { metaboxWrapper: groupSubcategoryMetaboxWrapper, mainConnectionTableRow: groupSubcategoryConnectionTableRow } ); + validatePublishButtonState( { groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton } ); + }, 2000 ); } -function validateConnectionState({ metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton }) { - const mainConnectionExists = document.querySelectorAll(mainConnectionTableRow).length >= 1; - const subConnectionExists = subConnectionTableRow ? document.querySelectorAll(subConnectionTableRow).length >= 1 : true; +function validateConnectionState( { metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton } ) { + const mainConnectionExists = document.querySelectorAll( mainConnectionTableRow ).length >= 1; - toggleMetaboxBorder(metaboxWrapper, mainConnectionExists); - validatePublishButtonState({ groupCategoryConnectionTableRow: mainConnectionTableRow, groupSubcategoryConnectionTableRow: subConnectionTableRow, postPublishButton }); + toggleMetaboxBorder( metaboxWrapper, mainConnectionExists ); + validatePublishButtonState( { groupCategoryConnectionTableRow: mainConnectionTableRow, groupSubcategoryConnectionTableRow: subConnectionTableRow, postPublishButton } ); } -function toggleMetaboxBorder(metaboxWrapper, connectionExists) { - const wrapper = document.querySelector(metaboxWrapper); - if (!wrapper) return; +function toggleMetaboxBorder( metaboxWrapper, connectionExists ) { + const wrapper = document.querySelector( metaboxWrapper ); + if ( ! wrapper ) return; - wrapper.style.border = connectionExists ? '' : '1px solid red'; + wrapper.style.border = connectionExists ? '' : '1px solid red'; } -function validatePublishButtonState({ groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton }) { - const categoryConnectionExists = document.querySelectorAll(groupCategoryConnectionTableRow).length >= 1; - const subcategoryConnectionExists = groupSubcategoryConnectionTableRow ? document.querySelectorAll(groupSubcategoryConnectionTableRow).length >= 1 : true; +function validatePublishButtonState( { groupCategoryConnectionTableRow, groupSubcategoryConnectionTableRow, postPublishButton } ) { + const categoryConnectionExists = document.querySelectorAll( groupCategoryConnectionTableRow ).length >= 1; + const subcategoryConnectionExists = groupSubcategoryConnectionTableRow ? document.querySelectorAll( groupSubcategoryConnectionTableRow ).length >= 1 : true; - const button = document.querySelector(postPublishButton); - if (!button) return; + const button = document.querySelector( postPublishButton ); + if ( ! button ) return; - button.disabled = !(categoryConnectionExists && subcategoryConnectionExists); + button.disabled = ! ( categoryConnectionExists && subcategoryConnectionExists ); } diff --git a/js/limit-item-connections.js b/js/limit-item-connections.js index 7bf1e4f..6ab6c2d 100644 --- a/js/limit-item-connections.js +++ b/js/limit-item-connections.js @@ -1,113 +1,97 @@ -document.addEventListener('DOMContentLoaded', () => { - const selectors = { - itemCategoryMetaboxWrapper: '#p2p-from-pdc-item_to_pdc-category', - itemSubcategoryMetaboxWrapper: '#p2p-from-pdc-item_to_pdc-subcategory', - itemGroupMetaboxWrapper: '#p2p-from-pdc-item_to_pdc-group', - - itemCategoryMetabox: 'div[data-p2p_type="pdc-item_to_pdc-category"]', - itemSubcategoryMetabox: 'div[data-p2p_type="pdc-item_to_pdc-subcategory"]', - itemGroupMetabox: 'div[data-p2p_type="pdc-item_to_pdc-group"]', - - itemCategoryConnectionTableRow: 'div[data-p2p_type="pdc-item_to_pdc-category"] > table.p2p-connections > tbody > tr', - itemSubcategoryConnectionTableRow: 'div[data-p2p_type="pdc-item_to_pdc-subcategory"] > table.p2p-connections > tbody > tr', - itemGroupConnectionTableRow: 'div[data-p2p_type="pdc-item_to_pdc-group"] > table.p2p-connections > tbody > tr', - - postPublishButton: 'div.edit-post-header__settings > button.editor-post-publish-button__button', - }; - - const { - itemCategoryMetaboxWrapper, - itemSubcategoryMetaboxWrapper, - itemGroupMetaboxWrapper, - itemCategoryMetabox, - itemSubcategoryMetabox, - itemGroupMetabox, - itemCategoryConnectionTableRow, - itemSubcategoryConnectionTableRow, - itemGroupConnectionTableRow, - postPublishButton, - } = selectors; - - // Monitor changes to metaboxes - observeMetaboxChanges(itemCategoryMetabox, itemCategoryMetaboxWrapper, itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, postPublishButton); - observeMetaboxChanges(itemSubcategoryMetabox, itemSubcategoryMetaboxWrapper, itemSubcategoryConnectionTableRow, itemCategoryConnectionTableRow, postPublishButton); - observeGroupMetaboxChanges(itemGroupMetabox, itemGroupConnectionTableRow); - - // Validate connections on page load - validateConnectionsOnLoad({ - itemCategoryMetaboxWrapper, - itemSubcategoryMetaboxWrapper, - itemGroupMetaboxWrapper, - itemCategoryConnectionTableRow, - itemSubcategoryConnectionTableRow, - itemGroupConnectionTableRow, - itemGroupMetabox, - postPublishButton, - }); -}); - -function observeMetaboxChanges(metabox, metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton) { - const observer = new MutationObserver(() => { - validateConnectionState({ metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton }); - }); - - const targetNode = document.querySelector(metabox); - if (targetNode) { - observer.observe(targetNode, { childList: true, subtree: true }); - } +document.addEventListener( 'DOMContentLoaded', () => { + const itemCategoryMetaboxWrapper = '#p2p-from-pdc-item_to_pdc-category'; + const itemSubcategoryMetaboxWrapper = '#p2p-from-pdc-item_to_pdc-subcategory'; + const itemGroupMetaboxWrapper = '#p2p-from-pdc-item_to_pdc-group'; + + const itemCategoryMetabox = 'div[data-p2p_type="pdc-item_to_pdc-category"]'; + const itemSubcategoryMetabox = 'div[data-p2p_type="pdc-item_to_pdc-subcategory"]'; + const itemGroupMetabox = 'div[data-p2p_type="pdc-item_to_pdc-group"]'; + + const itemCategoryConnectionTableRow = 'div[data-p2p_type="pdc-item_to_pdc-category"] > table.p2p-connections > tbody > tr'; + const itemSubcategoryConnectionTableRow = 'div[data-p2p_type="pdc-item_to_pdc-subcategory"] > table.p2p-connections > tbody > tr'; + const itemGroupConnectionTableRow = 'div[data-p2p_type="pdc-item_to_pdc-group"] > table.p2p-connections > tbody > tr'; + + const postPublishButton = 'div.edit-post-header__settings > button.editor-post-publish-button__button'; + + // Monitor changes to metaboxes + observeMetaboxChanges( itemCategoryMetabox, itemCategoryMetaboxWrapper, itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, postPublishButton ); + observeMetaboxChanges( itemSubcategoryMetabox, itemSubcategoryMetaboxWrapper, itemSubcategoryConnectionTableRow, itemCategoryConnectionTableRow, postPublishButton ); + observeGroupMetaboxChanges( itemGroupMetabox, itemGroupConnectionTableRow ); + + // Validate connections on page load + validateConnectionsOnLoad( { + itemCategoryMetaboxWrapper, + itemSubcategoryMetaboxWrapper, + itemGroupMetaboxWrapper, + itemCategoryConnectionTableRow, + itemSubcategoryConnectionTableRow, + itemGroupConnectionTableRow, + itemGroupMetabox, + postPublishButton, + } ); +} ); + +function observeMetaboxChanges( metabox, metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton ) { + const observer = new MutationObserver( () => { + validateConnectionState( { metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton } ); + } ); + + const targetNode = document.querySelector( metabox ); + if ( targetNode ) { + observer.observe( targetNode, { childList: true, subtree: true } ); + } } -function observeGroupMetaboxChanges(metabox, mainConnectionTableRow) { - const observer = new MutationObserver(() => { - toggleGroupConnectionVisibility(metabox, mainConnectionTableRow); - }); +function observeGroupMetaboxChanges( metabox, mainConnectionTableRow ) { + const observer = new MutationObserver( () => { + toggleGroupConnectionVisibility( metabox, mainConnectionTableRow ); + } ); - const targetNode = document.querySelector(metabox); - if (targetNode) { - observer.observe(targetNode, { childList: true, subtree: true }); - } + const targetNode = document.querySelector( metabox ); + if ( targetNode ) { + observer.observe( targetNode, { childList: true, subtree: true } ); + } } -function validateConnectionsOnLoad({ itemCategoryMetaboxWrapper, itemSubcategoryMetaboxWrapper, itemGroupMetaboxWrapper, itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, itemGroupConnectionTableRow, itemGroupMetabox, postPublishButton }) { - setTimeout(() => { - validateConnectionState({ metaboxWrapper: itemCategoryMetaboxWrapper, mainConnectionTableRow: itemCategoryConnectionTableRow }); - validateConnectionState({ metaboxWrapper: itemSubcategoryMetaboxWrapper, mainConnectionTableRow: itemSubcategoryConnectionTableRow }); - toggleGroupConnectionVisibility(itemGroupMetabox, itemGroupConnectionTableRow); - validatePublishButtonState({ itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, postPublishButton }); - }, 1000); +function validateConnectionsOnLoad( { itemCategoryMetaboxWrapper, itemSubcategoryMetaboxWrapper, itemGroupMetaboxWrapper, itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, itemGroupConnectionTableRow, itemGroupMetabox, postPublishButton } ) { + setTimeout( () => { + validateConnectionState( { metaboxWrapper: itemCategoryMetaboxWrapper, mainConnectionTableRow: itemCategoryConnectionTableRow } ); + validateConnectionState( { metaboxWrapper: itemSubcategoryMetaboxWrapper, mainConnectionTableRow: itemSubcategoryConnectionTableRow } ); + toggleGroupConnectionVisibility( itemGroupMetabox, itemGroupConnectionTableRow ); + validatePublishButtonState( { itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, postPublishButton } ); + }, 2000 ); } -function validateConnectionState({ metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton }) { - const mainConnectionExists = document.querySelectorAll(mainConnectionTableRow).length >= 1; - const subConnectionExists = subConnectionTableRow ? document.querySelectorAll(subConnectionTableRow).length >= 1 : true; +function validateConnectionState( { metaboxWrapper, mainConnectionTableRow, subConnectionTableRow, postPublishButton } ) { + const mainConnectionExists = document.querySelectorAll( mainConnectionTableRow ).length >= 1; - toggleMetaboxBorder(metaboxWrapper, mainConnectionExists); - validatePublishButtonState({ itemCategoryConnectionTableRow: mainConnectionTableRow, itemSubcategoryConnectionTableRow: subConnectionTableRow, postPublishButton }); + toggleMetaboxBorder( metaboxWrapper, mainConnectionExists ); + validatePublishButtonState( { itemCategoryConnectionTableRow: mainConnectionTableRow, itemSubcategoryConnectionTableRow: subConnectionTableRow, postPublishButton } ); } -function toggleMetaboxBorder(metaboxWrapper, connectionExists) { - const wrapper = document.querySelector(metaboxWrapper); - if (!wrapper) return; +function toggleMetaboxBorder( metaboxWrapper, connectionExists ) { + const wrapper = document.querySelector( metaboxWrapper ); + if ( ! wrapper ) return; - wrapper.style.border = connectionExists ? '' : '1px solid red'; + wrapper.style.border = connectionExists ? '' : '1px solid red'; } // Enforces that only one group connection can be made. Not sure why this is necessary, but it was in the original code. -function toggleGroupConnectionVisibility(metabox, mainConnectionTableRow) { - const createConnectionsElement = document.querySelector(`${metabox} > div.p2p-create-connections`); - const connectionExists = document.querySelectorAll(mainConnectionTableRow).length === 1; +function toggleGroupConnectionVisibility( metabox, mainConnectionTableRow ) { + const createConnectionsElement = document.querySelector( `${ metabox } > div.p2p-create-connections` ); + const connectionExists = document.querySelectorAll( mainConnectionTableRow ).length === 1; - if (!createConnectionsElement) return; + if ( ! createConnectionsElement ) return; - createConnectionsElement.classList.toggle('hidden', connectionExists); + createConnectionsElement.classList.toggle( 'hidden', connectionExists ); } -function validatePublishButtonState({ itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, postPublishButton }) { - const categoryConnectionExists = document.querySelectorAll(itemCategoryConnectionTableRow).length >= 1; - const subcategoryConnectionExists = itemSubcategoryConnectionTableRow ? document.querySelectorAll(itemSubcategoryConnectionTableRow).length >= 1 : true; +function validatePublishButtonState( { itemCategoryConnectionTableRow, itemSubcategoryConnectionTableRow, postPublishButton } ) { + const categoryConnectionExists = document.querySelectorAll( itemCategoryConnectionTableRow ).length >= 1; + const subcategoryConnectionExists = itemSubcategoryConnectionTableRow ? document.querySelectorAll( itemSubcategoryConnectionTableRow ).length >= 1 : true; - const button = document.querySelector(postPublishButton); - if (!button) return; + const button = document.querySelector( postPublishButton ); + if ( ! button ) return; - button.disabled = !(categoryConnectionExists && subcategoryConnectionExists); + button.disabled = ! ( categoryConnectionExists && subcategoryConnectionExists ); } diff --git a/js/limit-subtheme-connections.js b/js/limit-subtheme-connections.js index 26f4cac..b75b970 100644 --- a/js/limit-subtheme-connections.js +++ b/js/limit-subtheme-connections.js @@ -1,61 +1,51 @@ -document.addEventListener('DOMContentLoaded', () => { - const selectors = { - subCategoryCategoryMetaboxWrapper: '#p2p-to-pdc-category_to_pdc-subcategory', - subCategoryCategoryMetabox: 'div[data-p2p_type="pdc-category_to_pdc-subcategory"]', - subCategoryCategoryConnectionTableRow: 'div[data-p2p_type="pdc-category_to_pdc-subcategory"] > table.p2p-connections > tbody > tr', - postPublishButton: 'div.edit-post-header__settings > button.editor-post-publish-button__button', - }; - - const { - subCategoryCategoryMetabox, - subCategoryCategoryMetaboxWrapper, - subCategoryCategoryConnectionTableRow, - postPublishButton, - } = selectors; - - observeMetaboxChanges(subCategoryCategoryMetabox, subCategoryCategoryMetaboxWrapper, subCategoryCategoryConnectionTableRow, postPublishButton); - validateConnectionsOnLoad(subCategoryCategoryMetabox, subCategoryCategoryMetaboxWrapper, subCategoryCategoryConnectionTableRow, postPublishButton); -}); - -function observeMetaboxChanges(metabox, metaboxWrapper, connectionRow, postPublishButton) { - const observer = new MutationObserver(() => { - validateConnections({ metabox, metaboxWrapper, connectionRow, postPublishButton }); - }); - - const config = { childList: true, subtree: true }; - const targetNode = document.querySelector(metabox); - if (targetNode) { - observer.observe(targetNode, config); - } +document.addEventListener( 'DOMContentLoaded', () => { + const subCategoryCategoryMetaboxWrapper = '#p2p-to-pdc-category_to_pdc-subcategory'; + const subCategoryCategoryMetabox = 'div[data-p2p_type="pdc-category_to_pdc-subcategory"]'; + const subCategoryCategoryConnectionTableRow = 'div[data-p2p_type="pdc-category_to_pdc-subcategory"] > table.p2p-connections > tbody > tr'; + const postPublishButton = 'div.edit-post-header__settings > button.editor-post-publish-button__button'; + + observeMetaboxChanges( subCategoryCategoryMetabox, subCategoryCategoryMetaboxWrapper, subCategoryCategoryConnectionTableRow, postPublishButton ); + validateConnectionsOnLoad( subCategoryCategoryMetabox, subCategoryCategoryMetaboxWrapper, subCategoryCategoryConnectionTableRow, postPublishButton ); +} ); + +function observeMetaboxChanges( metabox, metaboxWrapper, connectionRow, postPublishButton ) { + const observer = new MutationObserver( () => { + validateConnections( { metabox, metaboxWrapper, connectionRow, postPublishButton } ); + } ); + + const targetNode = document.querySelector( metabox ); + if ( targetNode ) { + observer.observe( targetNode, { childList: true, subtree: true } ); + } } -function validateConnections({ metabox, metaboxWrapper, connectionRow, postPublishButton }) { - const connectionExists = document.querySelectorAll(connectionRow).length === 1; +function validateConnections( { metabox, metaboxWrapper, connectionRow, postPublishButton } ) { + const connectionExists = document.querySelectorAll( connectionRow ).length === 1; - toggleMetaboxState(metaboxWrapper, metabox, connectionExists); - togglePublishButton(connectionExists, postPublishButton); + toggleMetaboxState( metaboxWrapper, metabox, connectionExists ); + togglePublishButton( connectionExists, postPublishButton ); } -function toggleMetaboxState(metaboxWrapper, metabox, connectionExists) { - const wrapper = document.querySelector(metaboxWrapper); - const createConnectionsElement = document.querySelector(`${metabox} > div.p2p-create-connections`); - if (!wrapper || !createConnectionsElement) return; - - if (connectionExists) { - wrapper.style.border = ''; - createConnectionsElement.classList.add('hidden'); - } else { - wrapper.style.border = '1px solid red'; - createConnectionsElement.classList.remove('hidden'); - } +function toggleMetaboxState( metaboxWrapper, metabox, connectionExists ) { + const wrapper = document.querySelector( metaboxWrapper ); + const createConnectionsElement = document.querySelector( `${ metabox } > div.p2p-create-connections` ); + if ( ! wrapper || ! createConnectionsElement ) return; + + if ( connectionExists ) { + wrapper.style.border = ''; + createConnectionsElement.classList.add( 'hidden' ); + } else { + wrapper.style.border = '1px solid red'; + createConnectionsElement.classList.remove( 'hidden' ); + } } -function togglePublishButton(connectionExists, postPublishButton) { - document.querySelector(postPublishButton).disabled = !connectionExists; +function togglePublishButton( connectionExists, postPublishButton ) { + document.querySelector( postPublishButton ).disabled = ! connectionExists; } -function validateConnectionsOnLoad(metabox, metaboxWrapper, connectionRow, postPublishButton) { - setTimeout(() => { - validateConnections({ metabox, metaboxWrapper, connectionRow, postPublishButton }); - }, 1000); +function validateConnectionsOnLoad( metabox, metaboxWrapper, connectionRow, postPublishButton ) { + setTimeout( () => { + validateConnections( { metabox, metaboxWrapper, connectionRow, postPublishButton } ); + }, 2000 ); } diff --git a/pdc-base.php b/pdc-base.php index 350a3f0..3fae2de 100644 --- a/pdc-base.php +++ b/pdc-base.php @@ -4,7 +4,7 @@ * Plugin Name: Yard | PDC Base * Plugin URI: https://www.openwebconcept.nl/ * Description: Acts as foundation for other PDC related content plugins. This plugin implements actions to allow for other plugins to add and/or change Custom Posttypes, Metaboxes, Taxonomies, en Posts 2 posts relations. - * Version: 3.12.1 + * Version: 3.12.2 * Author: Yard | Digital Agency * Author URI: https://www.yard.nl/ * License: GPL-3.0 diff --git a/src/Base/Foundation/Plugin.php b/src/Base/Foundation/Plugin.php index 9c78d54..2518fc2 100644 --- a/src/Base/Foundation/Plugin.php +++ b/src/Base/Foundation/Plugin.php @@ -19,7 +19,7 @@ class Plugin * * @var string */ - public const VERSION = '3.12.1'; + public const VERSION = '3.12.2'; /** * Path to the root of the plugin.