Create Supporter CPT #149

lovestulip · 2024-11-18T20:33:13Z

Description

This request is to replicate the "Supporter" Custom Post Type (CPT) functionality from staging to production.

Ariel has tested the following code on the staging environment:

function display_cpt_supporters() {
    // Override the main query for this specific case
    query_posts(array(
        'post_type' => 'supporter',
        'posts_per_page' => -1,
        'orderby' => 'title',
        'order' => 'ASC'
    ));

    $output = '<div class="cpt-posts-container">';

    if (have_posts()) {
        while (have_posts()) {
            the_post();

            // Fetch ACF fields
            $name = get_field('name');
            $organization = get_field('organization');
            $quote = get_field('quote');
            $link = get_field('link');

            $output .= '<div class="cpt-post">';
            $output .= '<div class="supporter-info">';
            $output .= '<p><strong>' . esc_html($name) . '</strong><br />';

            // Check if the link field exists and is not empty
            if ($link) {
                $output .= '<i><a href="' . esc_url($link) . '" target="_blank">' . esc_html($organization) . '</a></i><br />';
            } else {
                $output .= '<i>' . esc_html($organization) . '</i><br />';
            }

            if ($quote) {
                $output .= '&quot;' . esc_html($quote) . '&quot;';
            }
            $output .= '</div>';
            $output .= '</div>';
        }
        wp_reset_query(); // Reset the query to the original
    } else {
        $output .= '';
    }

    $output .= '</div>';
    return $output;
}
add_shortcode('display_supporters', 'display_cpt_supporters');

Ariel has requested us to move this functionality to production and ensure it is safe to deploy without breaking existing functionality.

Context

See ZD link on the internal dev request.

The text was updated successfully, but these errors were encountered:

gin0115 · 2024-12-02T11:57:59Z

Hey

This has been added to staging. I have it ready to go into production along with #152

Also can confirm that just doing the export from ACF/SCF works for the post type and meta fields. Plus the WP export works fine for the post content too (i did this to test on my local)

If you would like me to importer those too, let me know :)

lovestulip · 2024-12-02T19:47:47Z

@ajolo2ky Can you please review the latest update and let us know how you'd like us to proceed?

ajolo2ky · 2024-12-04T04:32:46Z

Hi, thanks. Yes, please promote it to production.

Also, would it be possible in the wp-admin editing of the CPT, to remove the main body block and just show the custom fields?

gin0115 · 2024-12-04T10:20:57Z

I will get this pushed up now.

As for the content editor, you can remove that in the ACF Post Type settings

Do you want me to import the supporters that are present on the staging site? I have got the export file to hand (didn't share as this is a public repo)

ajolo2ky · 2024-12-04T15:09:49Z

Thanks! Yes, please import the ones that are already there.

gin0115 · 2024-12-04T15:56:56Z

I will try and hop on the computer and get them imported tonight 🙂

gin0115 · 2024-12-05T13:48:11Z

Didnt get a chance last night, but have imported them today.

gin0115 · 2024-12-12T14:19:34Z

This has all been imported, can we close this out now?

@lovestulip | @ajolo2ky

lovestulip · 2024-12-12T17:38:22Z

@ajolo2ky Can you please confirm?

ajolo2ky · 2024-12-16T19:25:00Z

Hi, sorry for the delay. This is worked, but the slug of supporters appears to be /blog/supporter/[supporter], it should be /supporter/[supporter] without /blog. Is that feasible? thanks.

gin0115 · 2024-12-17T11:44:04Z

I have changed the permalink locally, its all handled in the ACF settings

It was adding blog/supporter due to the sites main permalink settings

Do we want the post single to be accessible? As these are all just ACF meta fields, there is no content to render for the supporters.

We can use the same format as the shortcode supporter item for the post single views

lovestulip · 2024-12-19T23:07:38Z

@ajolo2ky Let us know your thoughts on the above when you can! Thank you so much!

ajolo2ky · 2025-01-08T18:55:21Z

Hi, sorry for the delay. I'm not finding the advanced settings box you are showing in the screenshot, where should that be inside of ACF?

Thanks,

gin0115 · 2025-01-09T11:51:47Z

Hi @ajolo2ky,

Apologies for not being clearer earlier! The setting you're looking for is located under Settings -> Permalinks. This isn't an ACF-specific setting—it's a general WordPress configuration.

I haven't made any changes to it since you currently have over 830 posts relying on that permalink structure (sorry for not checking this sooner).

If we want supporters to have URLs that exclude the /blog/, we might need to make some different changes. As it stands, those URLs for supporters will show a blank page unless we add a template.

ajolo2ky · 2025-01-09T13:27:44Z

Yes, we don't want to mess the current permalink structure. Can we remove the individual pages created by this CPT? I think that'd be faster.

gin0115 · 2025-01-09T14:08:47Z

Is the aim for the supporters only to be shown on a single page? if so we can remove the ability for supporters to have a /supporter/joe-bloggs url.

ajolo2ky · 2025-01-09T14:13:11Z

If we could have /supporter/ (instead of /blog/supporter), I'd prefer that. Having the unique URI for each supporter may have it's advantages. But if it's too problematic, for the time being I prefer just removing individual pages, just have them in /ai/endorsements and close this issue.

xpurichan · 2025-01-14T14:24:02Z

@gin0115 we'd also like to flag a related issue Ariel is experiencing, which is difficulty committing this PR:
#162

gin0115 · 2025-01-14T14:48:21Z

Sorry not forgotten about this, im suddenly swamped with lots of issues and struggling getting through them.

Will reply for pr162 on there directly

gin0115 · 2025-01-17T14:50:42Z

With this, it can be done using the acf settings

ive never used ACF to register post types, so didnt know it has this option.

This is done now, so links are not prefixed as /blog/supporter, now its just /supporter/

gin0115 · 2025-01-21T11:46:11Z

#192 has now gone up and I have changed the permalinks (as above). Suspsect we can close this out now.

lovestulip · 2025-01-21T17:12:41Z

@ajolo2ky Please confirm if we can consider this issue resolved. Thanks!

smaffulli · 2025-01-21T17:28:50Z

we get an error when trying to submit the form: [image: image.png]

…

On Tue, Jan 21, 2025 at 6:13 PM Nabaht ***@***.***> wrote: @ajolo2ky <https://github.com/ajolo2ky> Please confirm if we can consider this issue resolved. Thanks! — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKJJAASBJTFAVIPJH2O6GT2LZ52BAVCNFSM6AAAAABSAQIEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGMYDKMJSGE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

gin0115 · 2025-01-22T09:20:49Z

@smaffulli

Sorry you are having issues, ive copied the OSAID Endorsement contact form to my local version and im also getting issues on that form locally

{
    "contact_form_id": 24780,
    "status": "mail_failed",
    "message": "There was an error trying to send your message. Please try again later.",
    "posted_data_hash": "<REMOVED>",
    "into": "<REMOVED>",
    "invalid_fields": []
}

I removed the custom code that was uploaded to handle form submissions and i am still getting the same issue (locally)

{
    "contact_form_id": 24780,
    "status": "mail_failed",
    "message": "There was an error trying to send your message. Please try again later.",
     "posted_data_hash": "<REMOVED>",
    "into": "<REMOVED>",
    "invalid_fields": []
}

However it seems the mail was sent

Just so im not trying to compare apples to oranges, do you mind telling me what page the form is on?

smaffulli · 2025-01-22T09:31:37Z

I'm testing on this page: https://opensource.org/ai/endorsements the issue happens with Firefox but not always on Firefox Private... this may have something to do with ublock origin or something like that.

…

On Wed, Jan 22, 2025 at 10:21 AM Glynn Quelch ***@***.***> wrote: @smaffulli <https://github.com/smaffulli> Sorry you are having issues, ive copied the OSAID Endorsement contact form to my local version and im also getting issues on that form locally { "contact_form_id": 24780, "status": "mail_failed", "message": "There was an error trying to send your message. Please try again later.", "posted_data_hash": "<REMOVED>", "into": "<REMOVED>", "invalid_fields": [] } I removed the custom code that was uploaded to handle form submissions and i am still getting the same issue (locally) { "contact_form_id": 24780, "status": "mail_failed", "message": "There was an error trying to send your message. Please try again later.", "posted_data_hash": "<REMOVED>", "into": "<REMOVED>", "invalid_fields": [] } However it seems the mail was sent image.png (view on web) <https://github.com/user-attachments/assets/1d872dc5-8aa9-4365-8ab1-7bc4d7d9ab4b> Just so im not trying to compare apples to oranges, do you mind telling me what page the form is on? — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKJJABLT2RCEB3MY3QTZOL2L5PIRAVCNFSM6AAAAABSAQIEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWGY4TIMBRGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

gin0115 · 2025-01-22T09:41:58Z

Strange, i just submitted several submissions with different browsers and tried with ublock on or off.

CHROME (Regular)

Without

{
    "contact_form_id": 71702,
    "status": "mail_sent",
    "message": "Thank you for your message. It has been sent.",
    "posted_data_hash": "....",
    "into": "#wpcf7....",
    "invalid_fields": []
}

With

{
    "contact_form_id": 71702,
    "status": "mail_sent",
    "message": "Thank you for your message. It has been sent.",
    "posted_data_hash": "....",
    "into": "#wpcf7-...",
    "invalid_fields": []
}

FIREFOX (Regular)

{
    "contact_form_id":71702,
    "status":"mail_sent",
    "message":"Thank you for your message. It has been sent.",
    "posted_data_hash":"....",
    "into":"#wpcf7-....",
    "invalid_fields":[]
}

You don't have a pi hole or anything else running which could stop calls, do you?

(Tests from a linux machine)

smaffulli · 2025-01-22T09:47:50Z

No, nothing. i'm not on a vpn or other filter. We're receiving comments from users who have issues though, it's not just me.

…

On Wed, Jan 22, 2025 at 10:42 AM Glynn Quelch ***@***.***> wrote: Strange, i just submitted several submissions with different browsers and tried with ublock on or off. *CHROME (Regular)* Without { "contact_form_id": 71702, "status": "mail_sent", "message": "Thank you for your message. It has been sent.", "posted_data_hash": "....", "into": "#wpcf7....", "invalid_fields": [] } With { "contact_form_id": 71702, "status": "mail_sent", "message": "Thank you for your message. It has been sent.", "posted_data_hash": "....", "into": "#wpcf7-...", "invalid_fields": [] } *FIREFOX (Regular)* { "contact_form_id":71702, "status":"mail_sent", "message":"Thank you for your message. It has been sent.", "posted_data_hash":"....", "into":"#wpcf7-....", "invalid_fields":[] } You don't have a pi hole or anything else running which could stop calls, do you? (Tests from a linux machine) — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKJJAGPVFJCL3VKCEVB6O32L5RXZAVCNFSM6AAAAABSAQIEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWG42DEMRUG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

gin0115 · 2025-01-22T10:18:49Z

it is a strange one.

Do you want to open a new ticket for this, as it's not related to the supporter post type.

I just need to run some errands and I will look around online and see if anyone else is reporting this when I'm back.

smaffulli · 2025-01-22T10:21:46Z

I thought the issues were related. It's fine, we'll investigate this further and open a separate ticket

…

On Wed, Jan 22, 2025 at 11:19 AM Glynn Quelch ***@***.***> wrote: it is a strange one. Do you want to open a new ticket for this, as it's not related to the supporter post type. I just need to run some errands and I will look around online and see if anyone else is reporting this when I'm back. — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKJJADATZ7GQPCQWMDEP232L5WCXAVCNFSM6AAAAABSAQIEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWHAZTGMJSGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

gin0115 mentioned this issue Dec 2, 2024

Firefox print preview has artifacts #152

Closed

gin0115 self-assigned this Dec 5, 2024

ajolo2ky mentioned this issue Jan 8, 2025

OpenSource.org | Spreadsheet-to-text Zapier connection #116

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Supporter CPT #149

Create Supporter CPT #149

lovestulip commented Nov 18, 2024 •

edited

Loading

gin0115 commented Dec 2, 2024

lovestulip commented Dec 2, 2024

ajolo2ky commented Dec 4, 2024

gin0115 commented Dec 4, 2024

ajolo2ky commented Dec 4, 2024

gin0115 commented Dec 4, 2024 •

edited

Loading

gin0115 commented Dec 5, 2024

gin0115 commented Dec 12, 2024

lovestulip commented Dec 12, 2024

ajolo2ky commented Dec 16, 2024

gin0115 commented Dec 17, 2024

lovestulip commented Dec 19, 2024

ajolo2ky commented Jan 8, 2025

gin0115 commented Jan 9, 2025

ajolo2ky commented Jan 9, 2025

gin0115 commented Jan 9, 2025

ajolo2ky commented Jan 9, 2025

xpurichan commented Jan 14, 2025

gin0115 commented Jan 14, 2025

gin0115 commented Jan 17, 2025

gin0115 commented Jan 21, 2025

lovestulip commented Jan 21, 2025

smaffulli commented Jan 21, 2025 via email

gin0115 commented Jan 22, 2025

smaffulli commented Jan 22, 2025 via email

gin0115 commented Jan 22, 2025

smaffulli commented Jan 22, 2025 via email

gin0115 commented Jan 22, 2025

smaffulli commented Jan 22, 2025 via email

Create Supporter CPT #149

Create Supporter CPT #149

Comments

lovestulip commented Nov 18, 2024 • edited Loading

Description

Context

gin0115 commented Dec 2, 2024

lovestulip commented Dec 2, 2024

ajolo2ky commented Dec 4, 2024

gin0115 commented Dec 4, 2024

ajolo2ky commented Dec 4, 2024

gin0115 commented Dec 4, 2024 • edited Loading

gin0115 commented Dec 5, 2024

gin0115 commented Dec 12, 2024

lovestulip commented Dec 12, 2024

ajolo2ky commented Dec 16, 2024

gin0115 commented Dec 17, 2024

lovestulip commented Dec 19, 2024

ajolo2ky commented Jan 8, 2025

gin0115 commented Jan 9, 2025

ajolo2ky commented Jan 9, 2025

gin0115 commented Jan 9, 2025

ajolo2ky commented Jan 9, 2025

xpurichan commented Jan 14, 2025

gin0115 commented Jan 14, 2025

gin0115 commented Jan 17, 2025

gin0115 commented Jan 21, 2025

lovestulip commented Jan 21, 2025

smaffulli commented Jan 21, 2025 via email

gin0115 commented Jan 22, 2025

smaffulli commented Jan 22, 2025 via email

gin0115 commented Jan 22, 2025

smaffulli commented Jan 22, 2025 via email

gin0115 commented Jan 22, 2025

smaffulli commented Jan 22, 2025 via email

lovestulip commented Nov 18, 2024 •

edited

Loading

gin0115 commented Dec 4, 2024 •

edited

Loading