Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liberty HTTP2 FAT passing with Netty changes #26336

Open
isaacrivriv opened this issue Sep 20, 2023 · 1 comment
Open

Liberty HTTP2 FAT passing with Netty changes #26336

isaacrivriv opened this issue Sep 20, 2023 · 1 comment

Comments

@isaacrivriv
Copy link
Member

Working issue to track progress for HTTP2 FAT changes due to recent discoveries. Was able to get the tests running to 100% with the Netty H2C changes on #25953.

Started worked on rebasing the changes with Netty HTTP 1.1 updates and discovered issues with the tests. It was expecting a GO AWAY frame to run checks on frames received but it is not a requirement to answer a GO AWAY with a GO AWAY. Because of this, the tests were announcing false positives when they should have been failing while verifying the received frames. After making the updates to the tests to verify on every possible way of closing the connection started seeing a couple of issues that I'm working on.

@isaacrivriv
Copy link
Member Author

Was able to get to a point of having the entire http2 FAT passing on #26455 which contained some overlays in the Netty code and extensions of the classes in order to get things properly working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Identified Tasks
Development

No branches or pull requests

1 participant