From fc49de2317dd968340d43d5fda9de3eae0b15f94 Mon Sep 17 00:00:00 2001 From: Okke Harsta Date: Fri, 31 Jan 2025 10:36:55 +0100 Subject: [PATCH] Log stacktrace for UserNotFoundException --- account-gui/pom.xml | 2 +- myconext-gui/pom.xml | 2 +- myconext-server/pom.xml | 2 +- .../main/java/myconext/api/DefaultErrorController.java | 8 ++++---- .../java/myconext/exceptions/UserNotFoundException.java | 2 +- pom.xml | 2 +- public-gui/pom.xml | 2 +- tiqr-mock/pom.xml | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/account-gui/pom.xml b/account-gui/pom.xml index 5dba890c..9a57d7f7 100644 --- a/account-gui/pom.xml +++ b/account-gui/pom.xml @@ -4,7 +4,7 @@ org.openconext myconext - 7.4.4 + 7.4.5 ../pom.xml account-gui diff --git a/myconext-gui/pom.xml b/myconext-gui/pom.xml index fa9c1e7e..38a7789d 100644 --- a/myconext-gui/pom.xml +++ b/myconext-gui/pom.xml @@ -4,7 +4,7 @@ org.openconext myconext - 7.4.4 + 7.4.5 ../pom.xml myconext-gui diff --git a/myconext-server/pom.xml b/myconext-server/pom.xml index ad1b8888..f48d1595 100644 --- a/myconext-server/pom.xml +++ b/myconext-server/pom.xml @@ -4,7 +4,7 @@ org.openconext myconext - 7.4.4 + 7.4.5 ../pom.xml myconext-server diff --git a/myconext-server/src/main/java/myconext/api/DefaultErrorController.java b/myconext-server/src/main/java/myconext/api/DefaultErrorController.java index 733ccd36..f89b2f7e 100644 --- a/myconext-server/src/main/java/myconext/api/DefaultErrorController.java +++ b/myconext-server/src/main/java/myconext/api/DefaultErrorController.java @@ -56,11 +56,11 @@ public ResponseEntity error(HttpServletRequest request) throws URISyntaxExceptio statusCode = result.containsKey("status") && (int) result.get("status") != 999 ? HttpStatus.valueOf((int) result.get("status")) : INTERNAL_SERVER_ERROR; } else { - if (error instanceof UserNotFoundException) { - LOG.warn(String.format("%s: %s", error.getClass(), error.getMessage())); - } else { +// if (error instanceof UserNotFoundException) { +// LOG.warn(String.format("%s: %s", error.getClass(), error.getMessage())); +// } else { LOG.error(String.format("Error occurred; %s %s", error.getClass(), error), error); - } +// } //https://github.com/spring-projects/spring-boot/issues/3057 ResponseStatus annotation = AnnotationUtils.getAnnotation(error.getClass(), ResponseStatus.class); statusCode = annotation != null ? annotation.value() : BAD_REQUEST; diff --git a/myconext-server/src/main/java/myconext/exceptions/UserNotFoundException.java b/myconext-server/src/main/java/myconext/exceptions/UserNotFoundException.java index 86f44a45..2e2b2552 100644 --- a/myconext-server/src/main/java/myconext/exceptions/UserNotFoundException.java +++ b/myconext-server/src/main/java/myconext/exceptions/UserNotFoundException.java @@ -12,6 +12,6 @@ public UserNotFoundException(String message) { @Override protected boolean suppressStackTrace() { - return true; + return false; } } diff --git a/pom.xml b/pom.xml index 4363e050..33a87804 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 org.openconext myconext - 7.4.4 + 7.4.5 pom myconext My OpenConext diff --git a/public-gui/pom.xml b/public-gui/pom.xml index fbce27fd..38a32ece 100644 --- a/public-gui/pom.xml +++ b/public-gui/pom.xml @@ -4,7 +4,7 @@ org.openconext myconext - 7.4.4 + 7.4.5 ../pom.xml public-gui diff --git a/tiqr-mock/pom.xml b/tiqr-mock/pom.xml index b9930814..026acc17 100644 --- a/tiqr-mock/pom.xml +++ b/tiqr-mock/pom.xml @@ -4,7 +4,7 @@ org.openconext myconext - 7.4.4 + 7.4.5 ../pom.xml tiqr-mock