Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common object definitions from chapter/projects schema #784

Open
arkid15r opened this issue Feb 9, 2025 · 8 comments · May be fixed by #859
Open

Extract common object definitions from chapter/projects schema #784

arkid15r opened this issue Feb 9, 2025 · 8 comments · May be fixed by #859
Assignees
Labels

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Feb 9, 2025

Is your feature request related to a problem? Please describe.
In order to keep the schema DRY we want to extract common objects and reuse that definitions.

Describe the solution you'd like

  • create definitions directory for the new files
  • extract leaders definition to person.json schema
  • extract sponsor definition to sponsor.json schema
  • extract repository definition to repository.json schema
  • extract other definitions to the separate schema files for further reuse
  • create standardized tests for all fields in the new schema (null/undefined/non-unique/invalid)
  • keep the current chapter/project schema compatible by referencing local schema files, e.g.
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "sponsor": {
      "$ref": "./schema/definitions/sponsor.json"
    }
  }
}
@abhayymishraa
Copy link
Collaborator

can i work on this ?

@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Feb 9, 2025
@Yashgupta9330
Copy link
Collaborator

@arkid15r I want to work on this issue

@Rusheek
Copy link
Contributor

Rusheek commented Feb 9, 2025

Hi @arkid15r ,
I am interested in taking up this issue. Could you kindly assign it to me?

@arkid15r arkid15r moved this from Todo to In progress in Project Nest Feb 9, 2025
@arkid15r arkid15r moved this from In progress to Todo in Project Nest Feb 15, 2025
@AbhayTopno
Copy link
Collaborator

@arkid15r Can you assign this to me

@YourBroCode
Copy link
Contributor

@arkid15r I would like to work on this issue.

@yashgoyal0110
Copy link
Contributor

@arkid15r, can i work on it?

@arkid15r arkid15r moved this from Todo to In progress in Project Nest Feb 15, 2025
@arkid15r
Copy link
Collaborator Author

arkid15r commented Feb 15, 2025

@arkid15r Can you assign this to me

@AbhayTopno please note this is a blocker for further schema development.

@AbhayTopno
Copy link
Collaborator

@arkid15r I try my best to complete it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment