Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve lat and lon from results without using hasproperty #80

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

albangossard
Copy link
Member

See details in ODINN-SciML/Huginn.jl#65

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 38.18%. Comparing base (8384afc) to head (b45046e).

Files with missing lines Patch % Lines
src/simulations/results/results_plotting_utils.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   37.94%   38.18%   +0.24%     
==========================================
  Files          15       15              
  Lines         622      618       -4     
==========================================
  Hits          236      236              
+ Misses        386      382       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JordiBolibar JordiBolibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, nice cleaning.

@albangossard albangossard merged commit c9759a5 into main Feb 24, 2025
4 checks passed
@albangossard albangossard deleted the removeHaspropertyLatLon branch February 24, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants