Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Helper Function for PyObjects and Longitude/Latitude Integration in Results object #42

Closed
vivekag7 opened this issue Dec 7, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@vivekag7
Copy link
Contributor

vivekag7 commented Dec 7, 2023

The Results object in Sleipnir now includes longitude and latitude. However, this update caused errors in some Huginn tests, such as the Halfar solution, due to the absence of these new fields in these specific tests. To resolve this, a helper function was implemented to convert unavailable field values to a float value of 0.

This workaround is something we would like to avoid, so further inspection is needed in both Huginn and Sleipnir

@JordiBolibar JordiBolibar added the enhancement New feature or request label Dec 11, 2023
@JordiBolibar
Copy link
Member

@facusapienza21 @albangossard We should double check how the new coordinates in pure Julia affect the coordinates added in Results objects and the plotting functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants