Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Glathida files download work in parallel #39

Open
JordiBolibar opened this issue Dec 4, 2023 · 3 comments
Open

Make Glathida files download work in parallel #39

JordiBolibar opened this issue Dec 4, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@JordiBolibar
Copy link
Member

Right now the downloading of Glathida files with a pmap doesn't work. This should be fixed in the future in order to speed up the downloading of data for lots of glaciers.

@JordiBolibar JordiBolibar added the bug Something isn't working label Dec 4, 2023
@albangossard
Copy link
Member

albangossard commented Feb 24, 2025

I'm not sure this issue is still a thing.

Currently in the code we use filter_missing_glaciers!(rgi_ids::Vector{String}, params::Parameters) (and not filter_missing_glaciers!(glaciers::Vector{Glacier2D}, params::Parameters) which by the way could be removed) and this downloads one CSV for all the glaciers. There is no need of parallelism.

Additionally, since glathida data are now preprocessed with Gungnir, the function get_glathida_path_and_IDs is no longer used and I think that it can be removed.

So to sum up we should remove get_glathida_path_and_IDs and one of the implementation of filter_missing_glaciers!. @JordiBolibar do you agree with this conclusion?

@JordiBolibar
Copy link
Member Author

Yes, this is again legacy code. At the beginning we were doing a manual implementation of the downloading of Glathida. Later, this has been included officially in OGGM, so it's much easier.

@albangossard
Copy link
Member

Thank for this precision! I took profit of #79 to remove the two aforementioned functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants