Is there a reason for limiting clientid (option 61) to 48 bytes?

[gnaaman-dn]

Heya,

Is there a particular reason for clientid to be limited to 48 bytes?

#define CLIENTID_MAX_LEN	48

If I understand correctly, there's no such limit imposed by the RFC,
and it notes that the value can be an FQDN or an opaque object (I'm reading this as "an arbitrary byte sequence").

Does it make sense to raise this to 255, the same as the surrounding constants?

[rsmarples]

I don't see a reason why not. I looked through my source history and there's no obvious mention as to why I limited it.

[gnaaman-dn]

Thank you!
I'll open a PR then.

Have a nice day