Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting twice creates duplicate data in the results object #419

Open
nikml opened this issue Aug 14, 2024 · 2 comments
Open

Fitting twice creates duplicate data in the results object #419

nikml opened this issue Aug 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working stale

Comments

@nikml
Copy link
Contributor

nikml commented Aug 14, 2024

Describe the bug
Fitting twice creates duplicate data in the results object

To Reproduce
Steps to reproduce the behavior:
In the latest version run the code:

import nannyml as nml
from IPython.display import display
import warnings
warnings.filterwarnings("ignore")
reference_df, analysis_df, analysis_targets_df = nml.load_synthetic_car_loan_dataset()
analysis_df = analysis_df.merge(analysis_targets_df, left_index=True, right_index=True)
calc = nml.PerformanceCalculator(
    y_pred_proba='y_pred_proba',
    y_pred='y_pred',
    y_true='repaid',
    timestamp_column_name='timestamp',
    problem_type='classification_binary',
    metrics=['roc_auc',],
    chunk_size=20000)
calc.fit(reference_df)
calc.fit(reference_df)
results = calc.calculate(analysis_df)
display(results.to_df())

Expected behavior
Only 1 set of reference results would be present.

Screenshots & scripts

Screenshot 2024-08-13 at 16-35-54 20240813-4 r… (5) - JupyterLab

@nikml nikml added bug Something isn't working triage Needs to be assessed labels Aug 14, 2024
Copy link

stale bot commented Oct 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 19, 2024
@stale stale bot closed this as completed Oct 26, 2024
@nnansters nnansters removed triage Needs to be assessed stale labels Nov 4, 2024
@nnansters nnansters reopened this Nov 4, 2024
Copy link

stale bot commented Jan 3, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants