-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for some Pandas Extension Dtypes #399
Comments
Hey @Duncan-Hunter , good catch, good suggestion. I'll take a look into the Worst case scenario we can always add the extension dtypes to the list above. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe the bug
Pandas has extension DTypes. When you fit a Univariate calculator, or presumably anything that else that checks for dtypes using
_split_features_by_type
, columns are dropped becauseInt64
is not inTo Reproduce
Using an environment with
nannyml=0.10.7
Expected behavior
There should be support for these dtypes, and columns shouldn't be dropped without the user knowing.
Additional context
I'm going to work around the issue by converting my datatypes to underlying
numpy
types usingpd.Series.dtype.type
. But for a fix, I think you should usenp.issubdtype(dtype.type, np.number)
.The text was updated successfully, but these errors were encountered: