Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULE_IMPORT_NS should use string literal on Linux kernel 6.13-rc2+ #751

Open
1 task
xtexChooser opened this issue Dec 14, 2024 · 5 comments
Open
1 task

Comments

@xtexChooser
Copy link

NVIDIA Open GPU Kernel Modules Version

565.77

Operating System and Version

AOSC OS

Kernel Release

6.13.0-aosc-main

Please confirm you are running a stable release kernel (e.g. not a -rc). We do not accept bug reports for unreleased kernels.

  • I am running on a stable kernel release.

Build Command

dkms install

Terminal output/Build Log

In file included from /usr/src/linux-headers-6.13.0-aosc-main/include/linux/module.h:22,
                 from nvidia/nv.c:24:
nvidia/nv.c:130:18: error: expected ‘,’ or ‘;’ before ‘DMA_BUF’
  130 | MODULE_IMPORT_NS(DMA_BUF);
      |                  ^~~~~~~
/usr/src/linux-headers-6.13.0-aosc-main/include/linux/moduleparam.h:26:61: note: in definition of macro ‘__MODULE_INFO’
   26 |                 = __MODULE_INFO_PREFIX __stringify(tag) "=" info
      |                                                             ^~~~
/usr/src/linux-headers-6.13.0-aosc-main/include/linux/module.h:299:33: note: in expansion of macro ‘MODULE_INFO’
  299 | #define MODULE_IMPORT_NS(ns)    MODULE_INFO(import_ns, ns)
      |                                 ^~~~~~~~~~~
nvidia/nv.c:130:1: note: in expansion of macro ‘MODULE_IMPORT_NS’
  130 | MODULE_IMPORT_NS(DMA_BUF);
      | ^~~~~~~~~~~~~~~~

More Info

The parameter of MODULE_IMPORT_NS has been changed from constants to string literal: torvalds/linux@cdd30eb.

@noshricardo
Copy link

This is still an issue on the 6.13 stable release.

@ptr1337
Copy link

ptr1337 commented Jan 23, 2025

This is still an issue on the 6.13 stable release.

https://gitlab.archlinux.org/archlinux/packaging/packages/nvidia-utils/-/commit/101b429bbf1ff62947f50a7e983d0086db8f2df9

Here is the patches, we use on archlinux for 6.13 support. 565 will not get a release, and the next expected release will be together with the client blackwell release.

@noshricardo
Copy link

This is still an issue on the 6.13 stable release.

https://gitlab.archlinux.org/archlinux/packaging/packages/nvidia-utils/-/commit/101b429bbf1ff62947f50a7e983d0086db8f2df9

Here is the patches, we use on archlinux for 6.13 support. 565 will not get a release, and the next expected release will be together with the client blackwell release.

has this been applied to nvidia-open-dkms?

@ptr1337
Copy link

ptr1337 commented Jan 23, 2025

This is still an issue on the 6.13 stable release.

gitlab.archlinux.org/archlinux/packaging/packages/nvidia-utils/-/commit/101b429bbf1ff62947f50a7e983d0086db8f2df9
Here is the patches, we use on archlinux for 6.13 support. 565 will not get a release, and the next expected release will be together with the client blackwell release.

has this been applied to nvidia-open-dkms?

Yes, most of them are applied to nvidia-open. You can see it in the patch list in the PKGBUILD.

@aritger
Copy link
Collaborator

aritger commented Jan 23, 2025

My apologies for the delays in releasing a driver with Linux kernel 6.13 compatibility. I hope a release will be made soon. Thank you for your patience, and for the patches made by @ptr1337 .

For posterity, this MODULE_IMPORT_NS issue was tracked internally by NVIDIA as bug 5017197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants