Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated aliases in Thrust functional #3272

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Drop deprecated aliases in Thrust functional #3272

wants to merge 3 commits into from
+283 −1,069

Conversation

bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Jan 8, 2025 •
edited
Loading

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. breaking Breaking change labels Jan 8, 2025
@bernhardmgruber
Copy link
Contributor Author

/ok to test

miscco
miscco reviewed Jan 8, 2025
View reviewed changes
thrust/thrust/functional.h Outdated Show resolved Hide resolved
thrust/thrust/functional.h
{
return detail::not_fun_t<::cuda::std::decay_t<F>>{std::forward<F>(f)};
}
using ::cuda::std::not_fn;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm not_fn is a function template in cuda::std.

I am wondering why it is not being pulled in :thinking_face:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we probably need to merge the C++17 upgrade first, since cuda::std::not_fn requires it.

@bernhardmgruber bernhardmgruber marked this pull request as ready for review January 8, 2025 11:45
@bernhardmgruber bernhardmgruber requested review from a team as code owners January 8, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@gonidelis gonidelis Awaiting requested review from gonidelis gonidelis is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
breaking Breaking change thrust For all items related to Thrust.
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop deprecated ::result_type etc. from Thrust function objects (and alias them to the libcu++ ones)
2 participants
@bernhardmgruber @miscco