Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Switch to GPU for add_id by default and make that setting configurable #473

Open
VibhuJawa opened this issue Jan 7, 2025 · 0 comments · May be fixed by #479
Open

[IMP] Switch to GPU for add_id by default and make that setting configurable #473

VibhuJawa opened this issue Jan 7, 2025 · 0 comments · May be fixed by #479
Assignees
@VibhuJawa
Labels
enhancement New feature or request

Comments

@VibhuJawa
Copy link
Collaborator

While trying to add ids to 983 GB of data for a workflow but it took an hour+ of time.

I now realize that we hard code backend="pandas" here and that causes it

NeMo-Curator/nemo_curator/scripts/add_id.py

Lines 37 to 44 in 2d7e857

dataset = DocumentDataset(
read_data(
files, file_type=args.input_file_type, backend="pandas", add_filename=True
)
)
add_id = nemo_curator.AddId(
args.id_field_name, id_prefix=args.id_prefix, start_index=args.starting_index
)

We should default to GPU and make that configurable
@VibhuJawa VibhuJawa added the enhancement New feature or request label Jan 7, 2025
@VibhuJawa VibhuJawa self-assigned this Jan 7, 2025
@VibhuJawa VibhuJawa linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VibhuJawa VibhuJawa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable ADD ID to work with CPU/GPU both VibhuJawa/NeMo-Curator
1 participant
@VibhuJawa