refactor: Remove linkProperties from Stories Hub #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sandrahoang686
approved these changes
Jan 28, 2025
Base automatically changed from
refactor/remove-link-props-from-card-sources
to
main
January 28, 2025 09:07
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket:
Description of Changes
This removes the usage of
linkPropertiesapproach in favor of UseVedaUI's Link hook. Touched elements are:Notes & Questions About Changes
Validation / Testing
This PR does not attempt to fix #1404, so clicking on topic pill links won't apply filters. But they should be valid filter URLs.
To test:
This is ready for a review.