Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Component Implementation Spike #1393

Open
sandrahoang686 opened this issue Jan 21, 2025 · 0 comments
Open

Card Component Implementation Spike #1393

sandrahoang686 opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Jan 21, 2025

This is a spike to document the approach of how to build out the card component in a scalable way. Here are the Figma designs of the different card components we envision for the template instance. Currently cards are rendered by some big controller where we pass in the cardType and apply some styling. This isn't ideal or scalable and code needs to be cleaned up.

Implementing card will be iterative because there are quite a few different designs. And we need to deprecate the legacy card component safely since many components currently use it in veda-ui and GHG also uses the component directly.

Acceptance Criteria:

  • Create a POC PR or PRs with explanation of approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

No branches or pull requests

1 participant