Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LinkProperties throughout dashboard #1381

Open
3 of 5 tasks
sandrahoang686 opened this issue Jan 15, 2025 · 0 comments
Open
3 of 5 tasks

Remove LinkProperties throughout dashboard #1381

sandrahoang686 opened this issue Jan 15, 2025 · 0 comments
Assignees
@vgeorge @sandrahoang686
Labels
tech debt

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Jan 15, 2025 •
edited
Loading

A continuation of the work from...

Acceptance Critieria:

  • remove LinkProperties from new PageHeader (@sandrahoang686)
  • remove LinkProperties from new PageFooter
  • remove LinkProperties from HubContent
  • remove LinkProperties from CardSourcesList component
  • Update places that use the Card Component and remove linkProperties prop in favor of to
This was referenced Jan 15, 2025
Merged
Closed
@sandrahoang686 sandrahoang686 changed the title Link Placeholder Ticket Remove LinkProperties through dashboard Jan 15, 2025
@sandrahoang686 sandrahoang686 changed the title Remove LinkProperties through dashboard Remove LinkProperties throughout dashboard Jan 15, 2025
sandrahoang686 added a commit that referenced this issue Jan 21, 2025
@sandrahoang686
chore: Remove LinkProperties from PageHeader in favor of VedaUIProvid…
a84cc34 
…er (#1382)

**Related Ticket:** #1381
**Related PRs:** developmentseed/next-veda-ui#36

### Description of Changes
* Removed `LinkProperties` prop from PageHeader and down the tree. 
* Abstracted VedaUIProvider wrapper out so it can also wrap around tests
* Updated tests

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
* Make sure pageheader navigation is working as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgeorge vgeorge

@sandrahoang686 sandrahoang686

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vgeorge @sandrahoang686