-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline Package Release, Code cleanup and Next.js Deployment related to refactoring #1360
Closed
4 tasks done
Comments
4 tasks
hanbyul-here
added a commit
that referenced
this issue
Jan 14, 2025
**Related Ticket:** #1360 ### Description of Changes The reason I started looking at is I noticed that our library build has assets that are not supposed to be there (It started happening from ~ v5.9.0. If you build the library with v5.8, it builds clean.) All are quite small changes, (mainly changing the path for imports) + but lint change makes it look big :/ The changes in this PR so far do not fix the problem, but while we are on it let's clean up 🧹
This was referenced Jan 22, 2025
hanbyul-here
added a commit
that referenced
this issue
Jan 23, 2025
**Related Ticket:** #1360 This PR removes VEDA dependency from the registry build. Run `yarn buidlib`locally, see how less number of assets it builds to test it. (PageHeader and PageFooter were the root of the cause) --------- Co-authored-by: sandrahoang686 <[email protected]>
snmln
pushed a commit
that referenced
this issue
Feb 5, 2025
**Related Ticket:** #1360 ### Description of Changes The reason I started looking at is I noticed that our library build has assets that are not supposed to be there (It started happening from ~ v5.9.0. If you build the library with v5.8, it builds clean.) All are quite small changes, (mainly changing the path for imports) + but lint change makes it look big :/ The changes in this PR so far do not fix the problem, but while we are on it let's clean up 🧹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each of the item can be a separate issue. Using this issue to collect the items.
Package Management
Code Cleanup
I think I might have found the culprit:
veda-ui/app/scripts/components/common/page-header/nav/nav-item-cta.tsx
Line 3 in 552b7b8
Type Definitions
The text was updated successfully, but these errors were encountered: