Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Package Release, Code cleanup and Next.js Deployment related to refactoring #1360

Closed
4 tasks done
hanbyul-here opened this issue Jan 7, 2025 · 0 comments
Closed
4 tasks done
Assignees

Comments

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Jan 7, 2025

Each of the item can be a separate issue. Using this issue to collect the items.

Package Management

Code Cleanup

  • Ensure VEDA faux module dependency + dom router dependency doesn't exist in the library: Based on our library building result, something is still depending on VEDA faux module. (This is why the result includes various media from the stories.) Trace down where this dependency happens and remove it. It might be faster to just look up any import from 'veda' in component folder and replace it. @hanbyul-here

I think I might have found the culprit:

import { useFeedbackModal } from '../../layout-root';
This is basically importing everything from layout-root.

Type Definitions

@hanbyul-here hanbyul-here changed the title Streamline Package Release and Next.js Deployment related to refactoring Streamline Package Release, Code cleanup and Next.js Deployment related to refactoring Jan 8, 2025
hanbyul-here added a commit that referenced this issue Jan 14, 2025
**Related Ticket:** #1360 

### Description of Changes
The reason I started looking at is I noticed that our library build has
assets that are not supposed to be there (It started happening from ~
v5.9.0. If you build the library with v5.8, it builds clean.)

All are quite small changes, (mainly changing the path for imports) +
but lint change makes it look big :/

The changes in this PR so far do not fix the problem, but while we are
on it let's clean up 🧹
hanbyul-here added a commit that referenced this issue Jan 23, 2025
**Related Ticket:** #1360 

This PR removes VEDA dependency from the registry build. Run `yarn
buidlib`locally, see how less number of assets it builds to test it.
(PageHeader and PageFooter were the root of the cause)

---------

Co-authored-by: sandrahoang686 <[email protected]>
@aboydnw aboydnw mentioned this issue Feb 3, 2025
2 tasks
@aboydnw aboydnw closed this as completed Feb 3, 2025
snmln pushed a commit that referenced this issue Feb 5, 2025
**Related Ticket:** #1360 

### Description of Changes
The reason I started looking at is I noticed that our library build has
assets that are not supposed to be there (It started happening from ~
v5.9.0. If you build the library with v5.8, it builds clean.)

All are quite small changes, (mainly changing the path for imports) +
but lint change makes it look big :/

The changes in this PR so far do not fix the problem, but while we are
on it let's clean up 🧹
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants