Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Base to Pangeo 2024.11.11 #30

Open
wildintellect opened this issue Jan 7, 2025 · 2 comments
Open

Upgrade Base to Pangeo 2024.11.11 #30

wildintellect opened this issue Jan 7, 2025 · 2 comments

Comments

@wildintellect
Copy link
Contributor

@sunu @maxrjones I don't see clear instructions on what I should do to upgrade the base Pangeo image this builds on.

  1. Pull code and setup precommit?
  2. Make change and local test?
  3. Make PR from a fork so that the build is triggered on merge OR Make a branch and build is triggered on Push?
  4. Merge PR
  5. Go and make a PR from https://github.com/NASA-IMPACT/veda-hub-infrastructure to 2i2c?

Can you clarify these steps so I can try them out. Ideally I would deploy to VEDA hub staging first.

Reference ticket https://github.com/NASA-IMPACT/veda-analytics/issues/126#issuecomment-2484424569

@maxrjones
Copy link
Collaborator

Pull code and setup precommit?

Sounds right

Make change and local test?

Also sounds right

Make PR from a fork so that the build is triggered on merge OR Make a branch and build is triggered on Push?

Make a branch and build is triggered on push/PR (e.g., #28)

Merge PR

Would be good to request a review and do some smoke tests on the VEDA Hub using the built image before merging

Go and make a PR from https://github.com/NASA-IMPACT/veda-hub-infrastructure to 2i2c?

I think you would make a PR to https://github.com/2i2c-org/infrastructure and then sync https://github.com/NASA-IMPACT/veda-hub-infrastructure after the PR is merged into main.

@sunu
Copy link
Member

sunu commented Jan 8, 2025

Adding to what @maxrjones said

Would be good to request a review and do some smoke tests on the VEDA Hub using the built image before merging

To run the smoke tests on staging VEDA hub, we can use the custom image option in VEDA hub.

Before updating the image in https://github.com/2i2c-org/infrastructure, we should create a new version tag.

We have some basic automated snapshot tests in place. They sometimes break while upgrading the base image because the output differs from the recorded snapshot. If that happens, we need to regenerate the snapshot after verifying the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants