From 1a4be387c1e41b98030fed1c08b0865c664a8a32 Mon Sep 17 00:00:00 2001
From: Joseph Perez <joperez@dons.usfca.edu>
Date: Fri, 13 Oct 2023 09:13:00 -0700
Subject: [PATCH 1/2] fix(login-signup): add glean attributes

---
 components/nav/NavUser.vue          | 2 ++
 components/user/UserSignInEntry.vue | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/components/nav/NavUser.vue b/components/nav/NavUser.vue
index 8fe747c335..c9f3adefb9 100644
--- a/components/nav/NavUser.vue
+++ b/components/nav/NavUser.vue
@@ -29,6 +29,7 @@ const { busy, oauth, singleInstanceServer } = useSignIn()
         gap-x-1 items-center justify-center text-sm p-x-10px p-y-10px xl:hidden text-center font-600
         sm:mr-8px sm:btn-solid sm:btn-outline sm:b-rd-8px
         :disabled="busy"
+        data-glean="header.signup"
         @click="oauth('signup')"
       >
         {{ $t('action.create_account') }}
@@ -39,6 +40,7 @@ const { busy, oauth, singleInstanceServer } = useSignIn()
         gap-x-1 items-center justify-center text-sm font-600 p-x-11px p-y-11px xl:hidden
         sm:border-1 sm:border-primary sm:btn-outline sm:b-rd-8px
         :disabled="busy"
+        data-glean="header.login"
         @click="oauth()"
       >
         {{ $t('action.sign_in') }}
diff --git a/components/user/UserSignInEntry.vue b/components/user/UserSignInEntry.vue
index cb1bcce1e5..3392370a19 100644
--- a/components/user/UserSignInEntry.vue
+++ b/components/user/UserSignInEntry.vue
@@ -14,6 +14,7 @@ const { busy, oauth, singleInstanceServer } = useSignIn()
       v-if="singleInstanceServer"
       flex="~ row" gap-x-2 items-center justify-center btn-solid text-center rounded-3 font-500
       :disabled="busy"
+      data-glean="nav.signup"
       @click="oauth('signup')"
     >
       {{ $t('action.create_account') }}
@@ -22,6 +23,7 @@ const { busy, oauth, singleInstanceServer } = useSignIn()
       v-if="singleInstanceServer"
       flex="~ row" gap-x-2 items-center justify-center btn-outline text-center rounded-3 font-500
       :disabled="busy"
+      data-glean="nav.login"
       @click="oauth()"
     >
       {{ $t('action.sign_in') }}

From fdcf6599e49551f7edf33dbf1dc6723d1388fbfa Mon Sep 17 00:00:00 2001
From: Joseph Perez <joperez@dons.usfca.edu>
Date: Fri, 13 Oct 2023 10:57:55 -0700
Subject: [PATCH 2/2] fix(login-signup): register new events under
 engagementDetails map

---
 telemetry/engagementDetails.ts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/telemetry/engagementDetails.ts b/telemetry/engagementDetails.ts
index ca29cc8d4d..be64365da7 100644
--- a/telemetry/engagementDetails.ts
+++ b/telemetry/engagementDetails.ts
@@ -15,4 +15,16 @@ export const engagementDetails: EngagementDetails = {
   'settings.interface.themeColor': {
     engagement_type: 'general',
   },
+  'header.signup': {
+    engagement_type: 'general',
+  },
+  'header.login': {
+    engagement_type: 'general',
+  },
+  'nav.signup': {
+    engagement_type: 'general',
+  },
+  'nav.login': {
+    engagement_type: 'general',
+  },
 }