Merge pull request #18 from Mosibi/set_input_number_limits

Reverted registers 205 and 206 back to sensor, due to an issue. Set some min/max values to fix an issue with very high and low number limits
Mosibi · Jan 20, 2024 · ed64807 · ed64807
2 parents 622af08 + ecd8b34
commit ed64807
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 50 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,15 +5,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [2.0.0] - 2024-01-20
 
 ### Changed
 
+- Set some min/max values on numbers to fix an issue with very high and low number limits.
 - Documented default values for registers
 - Entity `heat_pump_running` is changed to check is the fan speed is above 0, the compressor frequency is above 0, or the water pump in the external unit is on. Previously only the fan speed was taken into account.
 - The following registers are changed from type `sensor` to `number` to make them configurable:
   - register: 205, Temperature Upper Limit Of TS Setting
+    - Reverted in a later commit due to an issue
   - register: 206, Temperature Lower Limit Of TS Setting
+    - Reverted in a later commit due to an issue
   - register: 207, Temperature Upper Limit Of water Heating
   - register: 208, Temperature Lower Limit Of Water Heating
   - register: 209, DHW Pump Return Running Time
@@ -35,6 +38,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - register: 227, T4cmin
   - register: 228, Time Interval Of Compressor Startup In Heating mode
 
+### Remarks
+
+- Many thanks to [Yocee84](https://github.com/Yocee84) with the help on issues #8 and #17
+
 ## [1.1.0] - 2024-01-13
 
 ### Changed

diff --git a/heatpump.yaml b/heatpump.yaml
@@ -521,6 +521,8 @@ sensor:
     address: 0x91
     value_type: U_DWORD
 
+  # The following register address 200-208 can only use 03H (Read register) function code.
+  # Register address 209 and after can use 03H, 06H (write single register), 10H (write multiple register).
   # Register: 200 (High byte)
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"
@@ -628,10 +630,46 @@ sensor:
     value_type: S_WORD
     unit_of_measurement: "°C"
     bitmask: 0xFF00
-  # Register: 205 -> Is present in this config as a 'number'
-  # Register: 206 -> Is present in this config as a 'number'
-  # Register: 207 -> Is present in this config as a 'number'
-  # Register: 208 -> Is present in this config as a 'number'
+  # Register: 205
+  - platform: modbus_controller
+    modbus_controller_id: "${devicename}"
+    name: "${entity_prefix} Temperature Upper Limit Of TS Setting"
+    id: "${devicename}_temperature_upper_limit_of_ts_setting"
+    register_type: holding
+    address: 0xcd
+    value_type: U_WORD
+    unit_of_measurement: "°C"
+    filters:
+      - multiply: 0.5
+  # Register: 206
+  - platform: modbus_controller
+    modbus_controller_id: "${devicename}"
+    name: "${entity_prefix} Temperature Lower Limit Of TS Setting"
+    id: "${devicename}_temperature_lower_limit_of_ts_setting"
+    register_type: holding
+    address: 0xce
+    value_type: U_WORD
+    unit_of_measurement: "°C"
+    filters:
+      - multiply: 0.5
+  # Register: 207
+  - platform: modbus_controller
+    modbus_controller_id: "${devicename}"
+    name: "${entity_prefix} Temperature Upper Limit Of water Heating"
+    id: "${devicename}_temperature_upper_limit_of_water_heating"
+    register_type: holding
+    address: 0xcf
+    value_type: U_WORD
+    unit_of_measurement: "°C"
+  # Register: 208
+  - platform: modbus_controller
+    modbus_controller_id: "${devicename}"
+    name: "${entity_prefix} Temperature Lower Limit Of Water Heating"
+    id: "${devicename}_temperature_lower_limit_of_water_heating"
+    register_type: holding
+    address: 0xd0
+    value_type: U_WORD
+    unit_of_measurement: "°C"
   # Register: 209 -> Is present in this config as a 'number'
   # Register: 212 -> Is present in this config as a 'number'
   # Register: 213 -> Is present in this config as a 'number'
@@ -1919,47 +1957,6 @@ number:
       ${devicename}->queue_command(set_payload_command);
 
       return {};
-
-  # Register: 205, default: 60, TODO: verify default
-  - platform: modbus_controller
-    modbus_controller_id: "${devicename}"
-    name: "${entity_prefix} Temperature Upper Limit Of TS Setting"
-    id: "${devicename}_temperature_upper_limit_of_ts_setting"
-    register_type: holding
-    address: 0xcd
-    value_type: S_WORD
-    unit_of_measurement: "°C"
-    entity_category: config
-  # Register: 206, default: 34, TODO: verify default
-  - platform: modbus_controller
-    modbus_controller_id: "${devicename}"
-    name: "${entity_prefix} Temperature Lower Limit Of TS Setting"
-    id: "${devicename}_temperature_lower_limit_of_ts_setting"
-    register_type: holding
-    address: 0xce
-    value_type: S_WORD
-    unit_of_measurement: "°C"
-    entity_category: config
-  # Register: 207, default: 60, TODO: verify default
-  - platform: modbus_controller
-    modbus_controller_id: "${devicename}"
-    name: "${entity_prefix} Temperature Upper Limit Of water Heating"
-    id: "${devicename}_temperature_upper_limit_of_water_heating"
-    register_type: holding
-    address: 0xcf
-    value_type: S_WORD
-    unit_of_measurement: "°C"
-    entity_category: config
-  # Register: 208, default: 20, TODO: verify default
-  - platform: modbus_controller
-    modbus_controller_id: "${devicename}"
-    name: "${entity_prefix} Temperature Lower Limit Of Water Heating"
-    id: "${devicename}_temperature_lower_limit_of_water_heating"
-    register_type: holding
-    address: 0xd0
-    value_type: S_WORD
-    unit_of_measurement: "°C"
-    entity_category: config
   # Register: 209, default: 5
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"
@@ -2238,16 +2235,18 @@ number:
     entity_category: config
     min_value: -15
     max_value: 10
-  # Register: 234, default: 5
+  # Register: 234, default: 5, TODO: verify min/max value
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"
     name: "${entity_prefix} Temperature Return Difference For Enabling The Hydraulic Module Auxiliary IBH"
     id: "${devicename}_dt1_ibh_on"
     register_type: holding
     address: 0xea
-    value_type: S_WORD
+    value_type: U_WORD
     unit_of_measurement: "°C"
     entity_category: config
+    min_value: 1
+    max_value: 7
   # Register: 235, default: 30
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"
@@ -2258,6 +2257,8 @@ number:
     value_type: U_WORD
     unit_of_measurement: min
     entity_category: config
+    min_value: 15
+    max_value: 120
   # Register: 237, default: 10, TODO: verify default
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"
@@ -2268,16 +2269,20 @@ number:
     value_type: S_WORD
     unit_of_measurement: "°C"
     entity_category: config
-  # Register: 238, default: 5
+    min_value: -15
+    max_value: 10
+  # Register: 238, default: 5, TODO: verify max/max value
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"
     name: "${entity_prefix} Trigger Temperature Difference Between T1S And Current Heat for AHS"
     id: "${devicename}_dt1_ahs_on"
     register_type: holding
     address: 0xee
-    value_type: S_WORD
+    value_type: U_WORD
     unit_of_measurement: "°C"
     entity_category: config
+    min_value: 1
+    max_value: 7
   # Register: 240, default: 30
   - platform: modbus_controller
     modbus_controller_id: "${devicename}"