Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Allow moving the MRTK settings asset #922

Open
Schroedingers-Cat opened this issue Sep 12, 2024 · 5 comments · May be fixed by #969
Open

[FEATURE REQUEST] Allow moving the MRTK settings asset #922

Schroedingers-Cat opened this issue Sep 12, 2024 · 5 comments · May be fixed by #969
Assignees
Labels
Priority: Medium The priority of the issue is medium. Type: Feature Request A request for a new feature that can be included with the next minor version release.

Comments

@Schroedingers-Cat
Copy link

Describe the problem

MRTK3 is adding visual noise to the Unity Assets root directory by placing its MRTKSettings.asset file in the MRTK.Generated directory. Moving this directory will break building causing an error that no profile has been defined for the current platform. The error is wrong and misleading because MRTK3 expects the MRTKSettings.asset at a specific location in the Assets directory.

Describe the solution you'd like

Previous versions of the MRTK (e.g. MRTK 2.8) had no problem moving the MRTK.Generated directory to a different place. It would be great if you could bring this back.

Describe alternatives you've considered

Moving the directory myself but that causes a build issue.

@Schroedingers-Cat Schroedingers-Cat added Needs: Triage Needs to be triaged. Type: Feature Request A request for a new feature that can be included with the next minor version release. labels Sep 12, 2024
@AMollis AMollis added Priority: Medium The priority of the issue is medium. and removed Needs: Triage Needs to be triaged. labels Sep 25, 2024
@AMollis
Copy link
Contributor

AMollis commented Sep 25, 2024

@keveleigh will investigate a fix to address this request.

@keveleigh keveleigh linked a pull request Jan 9, 2025 that will close this issue
@keveleigh
Copy link
Contributor

@Schroedingers-Cat, I've just opened #969 to fix this! If you have time, please give the change a try and ensure it works for your use case. Thank you!

@Schroedingers-Cat
Copy link
Author

@keveleigh thank you so much for the ping and the implementation!

I'm happy to test it out at the end of next week when I'm back at work. Since I'm using the MRTK Feature Tool to install MRTK3, I wonder if there is some documentation on how to install the git repo into a Unity project?

@keveleigh
Copy link
Contributor

keveleigh commented Jan 9, 2025

@Schroedingers-Cat which version of the Core package are you currently using? I can generate a one-off test package for you.

@keveleigh keveleigh linked a pull request Jan 10, 2025 that will close this issue
@Schroedingers-Cat
Copy link
Author

@keveleigh that would be great! I'm currently using org.mixedrealitytoolkit.core-3.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium The priority of the issue is medium. Type: Feature Request A request for a new feature that can be included with the next minor version release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants