Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new base16 repository #44

Open
xusiai opened this issue Jan 16, 2024 · 6 comments
Open

Switch to new base16 repository #44

xusiai opened this issue Jan 16, 2024 · 6 comments
Assignees

Comments

@xusiai
Copy link

xusiai commented Jan 16, 2024

The base16 repo linked in the readme has been archived in favor of the new repo here.

@Misterio77 Misterio77 self-assigned this Jan 30, 2024
@AviiNL
Copy link

AviiNL commented Feb 2, 2024

It already is, see:

base16-schemes.url = "github:tinted-theming/base16-schemes";

The links in the readme are not updated to match.

@xusiai
Copy link
Author

xusiai commented Feb 2, 2024

It already is, see:

No it isn't. Please look at the links above a bit closer.

@Misterio77
Copy link
Owner

Misterio77 commented Feb 13, 2024

Hey,

I love the new formt tinted theming uses, and I think it's the way to go. Sadly switching nix-colors to it is not as straight forward as I'd like.

The main problem is that there isn't really a pure nix yaml converter available. The one we're using is hackish and does not work with more complex (e.g. non-top level attributes) yaml, which the 0.11 spec now uses.

There's a few possibilities here:

  • Use IFD
    • Affects performance significantly
    • Requires changing our current colorSchemes.<scheme> interface to colorSchemes.<system>.<scheme>.
  • Pre-process and vendor JSON file(s) with the schemes
    • This was my approach before 2.0:
    • Will break the current feature that allows users to change the inputs.follows to switch nix-colors to different upstreams
  • Wait for Add support for parsing YAML NixOS/nix#7340
    • Even if merged, will be an experimental feature for a while, so not ideal either
  • Ask tinted theming to include JSON versions of the schemes (?)
  • Somehow try to make the current fromYaml function work with nested keys

@SenchoPens
Copy link

Hi @Misterio77, you can check out my fork of DavHau's fromYaml (BTW thanks for your MacOS regex fixes, I've used them there), it can read the new format (I successfully used it for my base16.nix lib)

@RusticCraftsman
Copy link

  • Pre-process and vendor JSON file(s) with the schemes

Seems conceptually unnecesary.

what about using something like yaml2nix's solution?

@Misterio77
Copy link
Owner

you can check out my fork of DavHau's fromYaml, it can read the new format (I successfully used it for my base16.nix lib)

Thank you so much for this @SenchoPens! Will definitely use it to make nix-colors compatible with the new format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants