Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Savestates do not work as expected #213

Open
5 tasks done
ScribbleTAS opened this issue Jul 13, 2024 · 0 comments
Open
5 tasks done

Savestates do not work as expected #213

ScribbleTAS opened this issue Jul 13, 2024 · 0 comments
Assignees
@ScribbleTAS
Labels
Savestates Issue is related to savestates TASFile Issue relates to the playback file used to store inputs

Comments

@ScribbleTAS
Copy link
Member

ScribbleTAS commented Jul 13, 2024 •
edited
Loading

I found a number of issues with savestates:

  • Player velocity is not applied after loading a savestate
  • When storing the TASfile, the first tick is incorrect
  • When loading a savestate during playback, the filecommands after the savestate are not properly loaded
  • Loading a savestate across dimensions crashes the game
  • Savestates fail to apply the correct motion

All of this leads to desyncs
@ScribbleTAS ScribbleTAS added Bug Something isn't working Savestates Issue is related to savestates TASFile Issue relates to the playback file used to store inputs labels Jul 13, 2024
@ScribbleTAS ScribbleTAS added this to the Beta1.0 milestone Jul 13, 2024
@github-project-automation github-project-automation bot moved this to Todo in TASmod Jul 13, 2024
@ScribbleTAS ScribbleTAS pinned this issue Jul 13, 2024
@ScribbleTAS ScribbleTAS mentioned this issue Jul 13, 2024
Merged
@ScribbleTAS ScribbleTAS linked a pull request Jul 13, 2024 that will close this issue
Savestate fixes #214
Merged
@ScribbleTAS ScribbleTAS self-assigned this Jul 13, 2024
@ScribbleTAS ScribbleTAS moved this from Todo to In Progress in TASmod Jul 13, 2024
@ScribbleTAS ScribbleTAS moved this from In Progress to Done in TASmod Jul 22, 2024
@ScribbleTAS ScribbleTAS moved this from Done to In Progress in TASmod Oct 10, 2024
@ScribbleTAS ScribbleTAS removed a link to a pull request Dec 13, 2024
Savestate fixes #214
Merged
@ScribbleTAS ScribbleTAS unpinned this issue Dec 13, 2024
@ScribbleTAS ScribbleTAS removed the Bug Something isn't working label Dec 13, 2024
@ScribbleTAS ScribbleTAS removed this from the Beta1.0 milestone Dec 13, 2024
@ScribbleTAS ScribbleTAS moved this from In Progress to Todo in TASmod Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScribbleTAS ScribbleTAS

Labels
Savestates Issue is related to savestates TASFile Issue relates to the playback file used to store inputs
Projects
TASmod
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScribbleTAS