Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling WebView2 Downloads - Complete Never Completes #4185

Closed
jarno9981 opened this issue Nov 21, 2023 · 8 comments
Closed

Handling WebView2 Downloads - Complete Never Completes #4185

jarno9981 opened this issue Nov 21, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@jarno9981
Copy link

jarno9981 commented Nov 21, 2023

What happened?

Code example's

just use the code from above or ask for the repo and you can reproduce

Importance

Important. My app's user experience is significantly compromised.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

119.0.2151.72

SDK Version

1.4.231115000

Framework

WinUI3/WinAppSDK

Operating System

Windows 11

OS Version

22631.2715

Repro steps

me when triggering the download you see it fire but after its 100% the ui closes but webview2 doesn't close the download operation but .completed is in the code

2023-11-21.19-22-29.mp4

here is a vidoe where it goes wrong
when closing app the download disseapers

Repros in Edge Browser

Yes

Regression

No, this never worked

Last working version (if regression)


@jarno9981 jarno9981 added the bug Something isn't working label Nov 21, 2023
@jarno9981 jarno9981 changed the title Handling WebView2 Downloads Handling WebView2 Downloads - Complete Never Completes Nov 21, 2023
@jarno9981
Copy link
Author

What i notice the current_path in de default db is never added but when removing args.handled it fixed but the old download dialog triggers

@victorhuangwq
Copy link
Collaborator

Hi @jarno9981 if you look at the #3268, it looks like it's because Edge flags that link as suspicious.

You can try updating the runtime and trying again. In the new version, this download is considered unsafe, so it will not be downloaded immediately. After clicking the '...' button, select 'Keep' to download the file. By reading this document mixed content downloads,you can learn about the reasons why the download is being blocked.

@jarno9981
Copy link
Author

Hi @jarno9981 if you look at the #3268, it looks like it's because Edge flags that link as suspicious.

You can try updating the runtime and trying again. In the new version, this download is considered unsafe, so it will not be downloaded immediately. After clicking the '...' button, select 'Keep' to download the file. By reading this document mixed content downloads,you can learn about the reasons why the download is being blocked.

Happens on more download sites for me sometimes it wont even start it keeps showing 0%

@victorhuangwq
Copy link
Collaborator

Could you provide links to the other sites? And also, could you check if for those sites, it repros in the Edge browser?

@jarno9981
Copy link
Author

@jarno9981
Copy link
Author

in edge they work fine

@victorhuangwq
Copy link
Collaborator

I tried the above links in the WebView2Sample app, and they do seem to work fine for me.

My SDK and runtime are as follows:
SDK build
1905.0
Runtime version
119.0.2151.72

Could you do a screen capture?

@jarno9981
Copy link
Author

I tried the above links in the WebView2Sample app, and they do seem to work fine for me.

My SDK and runtime are as follows: SDK build 1905.0 Runtime version 119.0.2151.72

Could you do a screen capture?

i fixed it by resetting the whole webview2 stuff for some reason it works fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants