Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting DefaultBackgroundColor method for WinUI2&WebView2 seems like needs to be updated #2862

Closed
SnowNooDLe opened this issue Oct 10, 2023 · 2 comments · Fixed by #2863
Closed

Setting DefaultBackgroundColor method for WinUI2&WebView2 seems like needs to be updated #2862

SnowNooDLe opened this issue Oct 10, 2023 · 2 comments · Fixed by #2863
Labels
ADO cat: webview2 WebView-related content.

Comments

@SnowNooDLe
Copy link
Contributor

SnowNooDLe commented Oct 10, 2023 •
edited by github-actions bot
Loading

Hey MS,

Based on the Environment file, I can see within the VS2022 Assembly System.Runtime.Extensions, Version=4.2.1.0

The Environment class doesn't seem to have SetVariable method. Instead, it now has a method called SetEnvironmentVariable

image

So I think the document needs to be updated from

Environment.SetVariable("WEBVIEW2_DEFAULT_BACKGROUND_COLOR", "FF000000");

to

Environment.SetEnvironmentVariable("WEBVIEW2_DEFAULT_BACKGROUND_COLOR", "FF000000");

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

AB#46971236
@SnowNooDLe SnowNooDLe mentioned this issue Oct 10, 2023
Merged
@mikehoffms mikehoffms linked a pull request Oct 10, 2023 that will close this issue
Update winui2.md to use SetEnvironmentVariable from Environment class for setting default background colour #2863
Merged
@captainbrosset
Copy link
Contributor

Thanks so much for reporting this and providing a PR to fix it!

@captainbrosset captainbrosset added cat: webview2 WebView-related content. ADO and removed triage-needed labels Oct 11, 2023
@SnowNooDLe
Copy link
Contributor Author

Thanks for the opportunity 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ADO cat: webview2 WebView-related content.
Projects
None yet
Milestone
No milestone
2 participants
@captainbrosset @SnowNooDLe