Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Test dApp sets low gas limit for EIP 1559 transactions #30167

Open
sleepytanya opened this issue Feb 6, 2025 · 1 comment · May be fixed by MetaMask/test-dapp#390
Open

[Bug]: Test dApp sets low gas limit for EIP 1559 transactions #30167

sleepytanya opened this issue Feb 6, 2025 · 1 comment · May be fixed by MetaMask/test-dapp#390
Assignees
Labels
regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Feb 6, 2025

Describe the bug

Test dApp sets low gas limit (20520) for EIP 1559 transactions:

sendEIP1559Button.onclick = async () => {
const result = await globalContext.provider.request({
method: 'eth_sendTransaction',
params: [
{
from: globalContext.accounts[0],
to: '0x0c54FcCd2e384b4BB6f2E405Bf5Cbc15a017AaFb',
value: '0x0',
gasLimit: '0x5028',
maxFeePerGas: '0x2540be400',
maxPriorityFeePerGas: '0x3b9aca00',
},
],
});
console.log(result);
};

Low gas limit is not present in 12.10.4.

Expected behavior

Gas limit should be 21000

Screenshots/Recordings

gas.mov
Image

Steps to reproduce

  1. Connect to the test dapp
  2. Start EIP 1559 transaction
  3. Check gas limit

Error messages or log output

Detection stage

In production (default)

Version

12.12.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added sev-2 team-confirmations Push issues to confirmations team type-bug Something isn't working labels Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 6, 2025
@metamaskbot metamaskbot added the regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 label Feb 6, 2025
@sleepytanya sleepytanya added regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 and removed regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 labels Feb 7, 2025
@metamaskbot metamaskbot added regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 and removed regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 labels Feb 7, 2025
@sleepytanya sleepytanya added Sev2-normal Normal severity; minor loss of service or inconvenience. regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 and removed sev-2 regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 labels Feb 7, 2025
@metamaskbot metamaskbot added regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 and removed regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 labels Feb 7, 2025
@pedronfigueiredo
Copy link
Contributor

We should use a higher gasLimit than 21000 to ensure the value is overriden by the dappSuggested one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

4 participants