Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate from CircleCI to GitHub Actions #33

Closed
legobeat opened this issue Jul 5, 2023 · 4 comments
Closed

ci: Migrate from CircleCI to GitHub Actions #33

legobeat opened this issue Jul 5, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@legobeat
Copy link
Contributor

legobeat commented Jul 5, 2023

This package should have workflows lifted from https://github.com/MetaMask/metamask-module-template/tree/main/.github/workflows instead of existing CircleCI jobs.

@legobeat legobeat added the good first issue Good for newcomers label Jul 5, 2023
@Najamulhassan3383
Copy link

Hi!
I am new to open source contribution and this will be my first contribution. If you have free time, can you plz explain the issue, what and how can i solve this?
It will be highly appreciated . Thanks

@legobeat
Copy link
Contributor Author

legobeat commented Jul 6, 2023

@Najamulhassan3383 Really appreciate the enthusiasm!

Briefly, this repo is currently using CircleCI for testing and linting configured in the .circleci directory of this repo. There has been a wider ongoing effort to consolidate MetaMask library repositories CI workflows to GitHub Actions, which this issue is part of.

metamask-module-template contains reusable workflows that this can be based on. Not everything will be relevant, here, though, and some amendments may need to be made.

The required workflows for this repo would be:

The docs-related workflows are not necessary here at this point.

For example, this was done in another repo here (older version) and here (update).

If you're up for taking a stab at this, I recommend creating a fork of this repo under your own account, then testing your work by making PRs (and releases) against your fork, linking to those successful runs once you feel ready to open a PR to address this issue here. example

Beyond this, you shouldn't expect much more guidance in figuring out specifics but if you're familiar with (or willing to familiarize yourself with) GHA workflows in general, this issue should hopefully be relatively straightforward.

@SurajAnand88
Copy link
Contributor

I've opened a PR for this issue

This was referenced Jul 7, 2023
@legobeat
Copy link
Contributor Author

Resolved in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants