Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Bug]: 'Switch to network' button is not fully visible #13191

Open
sleepytanya opened this issue Jan 27, 2025 · 4 comments
Open

[Bug]: [Bug]: 'Switch to network' button is not fully visible #13191

sleepytanya opened this issue Jan 27, 2025 · 4 comments
Labels
regression-RC-7.39.0 Regression bug that was found in release candidate (RC) for release 7.39.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Switch to network button text is not fully visible on iOS and Android devices.
It was introduced in 7.39.0 (1529) build, previous 7.38.0 (1528) doesn't have this issue.

Expected behavior

Text to confirm network switch is fully visible

Screenshots/Recordings

Image

Image

Steps to reproduce

  1. Add new network

Error messages or log output

Detection stage

During release testing

Version

7.39.0 (1537)

Build type

None

Device

iPhone15, Samsung S24 Ultra

Operating system

iOS, Android

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-RC-7.39 release-blocker This bug is blocking the next release Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets team-wallet-ux type-bug Something isn't working labels Jan 27, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 27, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 27, 2025
@sethkfman sethkfman added regression-RC-7.39.0 Regression bug that was found in release candidate (RC) for release 7.39.0 and removed regression-RC-7.39 labels Jan 27, 2025
@hesterbruikman
Copy link
Contributor

@sleepytanya @alfeng6 @darkwing I'm inclined to not treat this as release blocker because it's cosmetic and seems like a very easy copy fix. @alfeng6 can you confirm whether the Assets team can take this in the next 2 weeks?

The copy could be Switch Network regardless of the where it's used.

@hesterbruikman hesterbruikman removed the release-blocker This bug is blocking the next release label Jan 28, 2025
@alfeng6
Copy link

alfeng6 commented Jan 28, 2025

Definitely not a release blocker

@alfeng6
Copy link

alfeng6 commented Jan 28, 2025

We can take this on in the next 2 weeks

@hesterbruikman
Copy link
Contributor

@alfeng6 I forgot about this conversation, we concluded that we can remove the modal. Still ok for in the next two weeks, just logging the Slack conversation here for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.39.0 Regression bug that was found in release candidate (RC) for release 7.39.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants