refactor: Support permitted chains on permission confirmation page #30443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Gudahtt
force-pushed
the
fix-permission-connect-requested-chains
branch
3 times, most recently
from
4efb57b to
ea31a68
Compare
Builds ready [ea31a68]
Page Load Metrics (1677 ± 85 ms)
Bundle size diffs
|
Gudahtt
commented
Feb 24, 2025
| const requestedSessionsScopes = getRequestedSessionScopes( | ||
| _request.permission, | ||
| const requestedCaip25CaveatValue = getRequestedCaip25CaveatValue( | ||
| _request.permissions, |
There was a problem hiding this comment.
Looks like this was the main problem - there is no _request.permission. It's _request.permissions. This always blanked out the requested chain IDs in the request.
There was a problem hiding this comment.
Yeah, we came across and fixed this in the extension part of CAIP-25 merger refactor, but I haven't been able to get it reviewed and merged to main since the recent developments with the team unfortunately 😭
ffmcgee725
reviewed
Feb 25, 2025
| permissions?: PermissionsRequest, | ||
| ): Pick<Caip25CaveatValue, 'requiredScopes' | 'optionalScopes'> { | ||
| ): Caip25CaveatValue { |
There was a problem hiding this comment.
ty for this fix 🙏🏾 amidst the multiple requests to change how this function worked, I eventually must have forgotten to update the actual return value to include isMultichainOrigin 🤦🏾
Gudahtt
added
the
needs-dev-review
itsyoboieltr
previously approved these changes
Feb 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The permissions confirmation page currently ignores the `requestedChainIds` prop when the connection is confirmed. This hasn't resulted in a bug because this page is only used for snap permissions. Permission requests for `eth_account` or `endowment:permitted-chains` are handled by the "ChooseAccount" or "ConnectPage" components (the former if a snap is also requested alongside, the latter otherwise). This PR fixes the problem regardless, as it's confusing for the component to have this prop but to ignore it when processing the confirmation. This was extracted from #27782
Gudahtt
force-pushed
the
fix-permission-connect-requested-chains
branch
from
ea31a68 to
e7bda56
Compare
Gudahtt
dismissed stale reviews from itsyoboieltr and ffmcgee725
via
4ec183d
Builds ready [4ec183d]
Page Load Metrics (1776 ± 90 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The permissions confirmation page currently ignores the
requestedChainIdsprop when the connection is confirmed. This hasn't resulted in a bug because this page is only used for snap permissions. Permission requests foreth_accountorendowment:permitted-chainsare handled by the "ChooseAccount" or "ConnectPage" components (the former if a snap is also requested alongside, the latter otherwise).This PR fixes the problem regardless, as it's confusing for the component to have this prop but to ignore it when processing the confirmation.
This was extracted from #27782
Related issues
See this comment for some additional context: https://github.com/MetaMask/metamask-extension/pull/27782/files#r1936463248
Manual testing steps
N/A, the impacted functionality is unreachable.
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist