Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Crowdin translations by Github Action #28996

Open
wants to merge 932 commits into
base: develop
Choose a base branch
from
Open

New Crowdin translations by Github Action #28996

wants to merge 932 commits into from
+156,894 −142,624

Conversation

metamaskbot
Copy link
Collaborator

No description provided.

@metamaskbot metamaskbot requested a review from a team as a code owner December 6, 2024 15:27
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from bfd46e0 to 48faa78 Compare December 6, 2024 15:27
@metamaskbot metamaskbot added the team-bot Bot team (for MetaMask Bot) label Dec 6, 2024
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 48faa78 to 7bcf84b Compare December 6, 2024 15:56
@github-actions github-actions bot requested review from a team, HowardBraham and kumavis as code owners December 6, 2024 15:56
@socket-security Socket Security
Copy link

socket-security bot commented Dec 6, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/@chainsafe/[email protected] 🚫
Network access npm/@viem/[email protected] 🚫
Network access npm/@viem/[email protected] 🚫
Shell access npm/[email protected] 🚫
New author npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/@firebase/[email protected] 🚫
Network access npm/@firebase/[email protected] 🚫
AI-detected potential code anomaly npm/[email protected]
  • Notes: The code appears to be performing cryptographic operations related to application security and transaction processing. However, due to the obfuscated nature of some function calls and the unconventional style, there is a moderate security risk and low confidence in the overall integrity of the code.
  • Confidence: 1.00
  • Severity: 0.60
 ⚠︎
Network access npm/@metamask/[email protected] 🚫
New author npm/@metamask/[email protected] 🚫
Unstable ownership npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫
New author npm/@metamask/[email protected] 🚫
Unstable ownership npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫
Medium CVE npm/[email protected] ⚠︎
Network access npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫
Unstable ownership npm/@metamask/[email protected] 🚫
New author npm/@metamask/[email protected] 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is an AI-detected potential code anomaly?

AI has identified unusual behaviors that may pose a security risk.

An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the number of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

What is a medium CVE?

Contains a medium severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known medium severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 12 times, most recently from a985b35 to 2f5ca29 Compare December 10, 2024 10:28
@danjm
refactor: Use browser.runtime.onInstalled instead of a check for empt…
da8838f 
…y storage,… (#29826)

## **Description**

We currently decide whether the current running of initBackground in
background.js is a first time install (vs a post install
opening/loading/initialization, as would happen upon opening the browser
or reloading the service worker) by checking if the store exists (prior
to loadStateFromPersistance)
https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/background.js#L1301

However, because state can be corrupted or possibly missing, we no
longer can assume that the absence of the store always means that it is
a first time install.

As such, it would be best if we could implement a way to track whether
it is a first time install that was not dependent on pre-existing stored
data. This PR does this by using the browser.runtime.onInstalled event
handler

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29826?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#4192

## **Manual testing steps**

1. Checkout this branch, build, install and open
2. Open the service worker console and go to the networks tab
3. Go through onboarding and opt in to metametrics
4. There should be an "App installed" event in a network request sent to
segment
5. Complete onboarding
6. Reload the extension from chrome://extensions and open the service
worker. There should be no "App installed" event in a network request to
segment

Also, `test/e2e/tests/metrics/app-installed.spec.ts` should pass

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 7210eb2 to 87516ee Compare February 24, 2025 19:44
@david0xd
feat(multichain-connect-ui): Add UI preparation changes for multichai…
32af047 
…n connection flow (#30164)

## **Description**
This PR updates connection flow to prepare it for multichain
connection/permission/account requests.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30164?quickstart=1)

## **Related issues**
Fixes: MetaMask/MetaMask-planning#3899

Epic: MetaMask/MetaMask-planning#3660

Design:
https://www.figma.com/design/TVuSsLlBQGypLamTsjN1hG/Connection?node-id=286-3221&p=f&t=FkFfpgICtIpA2WBY-0

## **Notes**
- `AccountListItem` will be updated to handle network icons in this task
here: MetaMask/MetaMask-planning#4056 (when
done, it can be integrated into the connection flow, but for now it's
alright to not have it, since it's not a blocker).

## **Manual testing steps**
1. Go to test-dapp.
2. Request permissions / request to connect.
3. Check UI functionality and designs.
4. Check edge cases.
5. Confirm functionality of the entire flow.

## **Screenshots/Recordings**
### **Before**
![Screenshot 2025-02-11 at 17 26
59](https://github.com/user-attachments/assets/18348f1c-3c12-481f-a346-4ecf05585125)
![Screenshot 2025-02-11 at 17 27
27](https://github.com/user-attachments/assets/fe827d6c-2613-4343-afbf-3d8cd0b4a5c8)
![Screenshot 2025-02-11 at 17 27
57](https://github.com/user-attachments/assets/2152b2fb-c20c-4c61-beb5-ce782040fae3)

### **After**

https://github.com/user-attachments/assets/9e47ac9c-b0de-4e84-ba41-2d72c6d9fe10

#### Regular flows
![Screenshot 2025-02-13 at 20 20
04](https://github.com/user-attachments/assets/889953f8-cbe2-4c33-bf60-649b4d77040c)
![Screenshot 2025-02-13 at 20 20
18](https://github.com/user-attachments/assets/043c5270-be4f-4e41-84ed-53885505a3fe)
![Screenshot 2025-02-13 at 20 20
31](https://github.com/user-attachments/assets/fb32e6f1-f148-4bc7-93d6-ec0f8100b18d)
![Screenshot 2025-02-13 at 20 21
41](https://github.com/user-attachments/assets/991c02e5-5065-407b-922c-c198c285f31f)

#### IP address as a hostname and missing icon handling
![Screenshot 2025-02-13 at 23 19
41](https://github.com/user-attachments/assets/55707212-11e3-4734-a156-741c6ab1baf9)
![Screenshot 2025-02-13 at 23 19
19](https://github.com/user-attachments/assets/87371e18-09ad-4a94-bac6-4883da765d61)
![Screenshot 2025-02-13 at 23 19
59](https://github.com/user-attachments/assets/35aa3456-37e4-4d74-ac36-6b54f5744052)

#### Empty state edge case handling

https://github.com/user-attachments/assets/4ae87104-1e6e-4de3-aa3f-0b2f4b28e1fc

## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 3d5b5c8 to 56ae5c6 Compare February 25, 2025 00:21
@gambinish
fix: Nft chainId and current global chainId arent always the same (#3…
78c5d2c 
…0517)

## **Description**

Fixes a bug, where the network badge on the top of the nft in the nft
details page did not correspond to the chain it belonged to. This
resulted in navigating to send screen on a network that the NFT did not
belong to.

This PR introduces two things:

1. Show correct NFT chain badge on NFT details screen, regardless of
which network user is on
2. When navigating to the send flow for an NFT, where the network the
NFT belongs to is not the globally selected chainId, change the network
on behalf of the user so that the globally selected chainId is the same
as the NFT being sent.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30517?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to NFT Grid
2. Navigate to an NFT details screen on Ethereum Mainnet
3. Change global network to Linea
4. Should not see the network badge change on the NFT
5. Click send
6. See that network is changed on behalf of user from Linea back to
Ethereum, where the NFT belongs

## **Screenshots/Recordings**

### **Before**


https://github.com/user-attachments/assets/a2620999-6ce5-4d10-91ec-2531063ee2ca

### **After**


https://github.com/user-attachments/assets/06d294eb-73d6-46ba-aa75-b463d6da0a66

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 56ae5c6 to 840c06e Compare February 25, 2025 01:19
danroc and others added 2 commits February 25, 2025 10:11
@danroc
feat(snap-keyring): handle displayAccountNameSuggestion flag (#30531)
32c2077 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR handles the `displayAccountNameSuggestion` flag that can be set
by pre-installed Snaps in the `accountCreated` event.

<!-- **BREAKING**: By default, dialogs are displayed now. -->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30531?quickstart=1)

## **Related issues**

Fixes: MetaMask/accounts-planning#829

## **Manual testing steps**

1. Update a pre-installed Snap to set `displayAccountNameSuggestion` to
false:

   ```diff
diff --git a/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   b/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   index 27238e7..6edabc7 100644
   --- a/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   +++ b/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   @@ -224,7 +224,8 @@ export class SolanaKeyring implements Keyring {
             * and the snaps sdk does not allow extra properties.
             */
            account: keyringAccount,
   -        accountNameSuggestion: `Solana Account ${index + 1}`,
   +        accountNameSuggestion: `Solana Account`,
   +        displayAccountNameSuggestion: false,
          });
   
          return keyringAccount;
   ```

2. Build the Snap and add a resolution in the extension's
`package.json`:

   ```
"@metamask/solana-wallet-snap@^1.2.0":
"file:../snap-solana-wallet/packages/snap"
   ```

3.  Start the extension: `yarn && yarn start:flask`

4. Create an account

5. The account name dialog should not be shown

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@aganglada
feat: replace experimental add solana account with remote flag (#30487)
0ad093f 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

- [x] Removes experimental `Enable "Add Solana account"` setting
- [x] Adds remote feature flag fence
- [x] Enable feature in `flask - dev` 

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30487?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Add `MANIFEST_OVERRIDES=.manifest-overrides.json` to the
`.metamaskrc`
2. Create a `.manifest-overrides.json` file 
3. Add the following content
```
{
  "_flags": {
    "remoteFeatureFlags": { "addSolanaAccount": true }
  }
}
```
4. Build
5. Modify the value to test both cases (enabled/disabled)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from b262291 to 366263c Compare February 25, 2025 10:50
@Mrtenz
fix: Add snap_experimentalProviderRequest to unrestricted methods (#…
2fffd78 
…30525)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This adds `snap_experimentalProviderRequest` to the list of unrestricted
methods.

> [!NOTE]
> This method is experimental, and will be removed in a future update.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30525?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 918a5e4 to 67442c2 Compare February 25, 2025 12:08
@pedronfigueiredo
fix: clear transaction data after submission or cancellation (#30546)
5ddd7e9 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30546?quickstart=1)

## **Related issues**

Fixes: #29374

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 67442c2 to 0d4ff87 Compare February 25, 2025 13:23
desi and others added 2 commits February 25, 2025 17:22
@desi
feat(ci): Auto add needs-triage label on bug open (#30512)
5c6862f 
## **Description**

We use the stale bot in order to make sure we close out issues which
have been open and waiting on additional information from reporters for
too long. However, sometimes this can be the case for issues that we
just haven't had an opportunity to follow back up on. We feel a couple
of process improvements can make this better.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30512?quickstart=1)

## **Related issues**

Partially fixes:
MetaMask/MetaMask-planning#4219

Related to:
https://github.com/MetaMask/github-tools/pull/41/files


## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@Gudahtt
chore: Expose extension ID to E2E tests (#30539)
9a9513b 
## **Description**

The E2E test setup function (`withFixtures`) has been updated to pass
the extension ID to E2E tests. This will be useful in the near future
for testing the new multichain API, which is exposed over
`externally_connectable` and requires the extension ID to use.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30539?quickstart=1)

## **Related issues**

This was extracted from #27782

## **Manual testing steps**

N/A, this isn't used yet so there is nothing to manually test.

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 515f341 to b2f6656 Compare February 25, 2025 18:11
gantunesr and others added 3 commits February 25, 2025 19:31
@gantunesr
refactor: refactor network picker (#30433)
3726202 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30433?quickstart=1)



## **Related issues**

Fixes: MetaMask/accounts-planning#833
Fixes: MetaMask/accounts-planning#811

## **Manual testing steps**

Note: UX changes should only be present in Flask/Beta

1. Go to the experimental settings view and enable Solana
2. See that the Solana network is now added to the network picker
3. Select the network
4. An account creation flow should be displayed
5. Complete the flow and add a Solana account
6. Change multiple times between accounts and networks
7. Verify that the relation network-account is always correct
    - Solana Account <> Solana Network
    - EVM Account <> EVM Network 

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/868bde81-7b2e-4a0f-8658-caf2a7ee324a

### **After**


https://github.com/user-attachments/assets/c8578eba-e079-4aaf-90be-d76881a8d4ee

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@Prithpal-Sooriya
feat: bump notifications services controller to v1.0.0 (#30532)
cfba6a9 
## **Description**

Bumps notification services to v1.0.0.

Includes quite a bit of under the hood changes, but most changes were to
support mobile changes.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30532?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

Attempt full notifications flow
1. Enable/Disable Notifications
2. Enable/Disable Account Notifications
3. Enable/Disable Feature Announcements
4. Create a transaction to perform a push notification and notification.

## **Screenshots/Recordings**

Demo Full Notifications Flow:

https://www.loom.com/share/453aead2dc504de8a7d0e3d8fa13c639?sid=7fe129af-a02d-4800-9fc0-bd1f0b7ff43f

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@salimtb
fix: upgrade assets controllers to v51.0.2 (#30563)
ce68358 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
bump assets controller to v51.0.2

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30563?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to node_modules
2. check the assets-controllers version

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 3 times, most recently from db15f1f to 34a7d4d Compare February 25, 2025 20:37
micaelae and others added 2 commits February 25, 2025 22:27
@micaelae
refactor: support non-evm tokens in asset-picker (#30313)
64dbed6 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
The main goal of this PR is to enable displaying non-evm tokens and
their balances in the AssetPicker. The general approach is to find
instances in which components and hooks read evm-specific data and
replace them with multichain equivalents

In addition to that, this enables networks that use CAIP chainIds to be
selectable in the asset-picker

Changes
- types: allow non-hex chainId values
- asset-picker-modal: show non-evm tokens that have balances
- AssetList.tsxm asset-picker: read currency and account balance info
from multichain selectors
- Asset.tsx: read token data from props instead of getTokenList selector
- token-list-item: only parse chainId as in if it's a hex value
- useMultichainBalances: calculate token balances for non-evm tokens and
include them in resulting sorted list
- multichain.ts: add a placeholder network configuration for solana

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30313?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Set `BRIDGE_USE_DEV_APIS=1` in .metamaskrc
1. Swap + Send flow should still work for EVM chains
2. Bridge flow should still work when bridging EVM -> EVM

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**




https://github.com/user-attachments/assets/1a109439-2855-4d7a-ae90-1637a6abceb5



## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
New Crowdin translations by Github Action
2ed859f
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 34a7d4d to 2ed859f Compare February 25, 2025 23:01
@socket-security Socket Security
Copy link

Report too large to display inline

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees
No one assigned
Labels
team-bot Bot team (for MetaMask Bot)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.