Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor keyring-controller to remove QR keyring methods #4341

Open
gantunesr opened this issue May 30, 2024 · 3 comments
Open

Refactor keyring-controller to remove QR keyring methods #4341

gantunesr opened this issue May 30, 2024 · 3 comments
Labels
team-wallet-framework

Comments

@gantunesr
Copy link
Member

gantunesr commented May 30, 2024 •
edited
Loading

Description

Given the latest refactor in the keyring-controller, it's now possible to deprecate all keyring specific methods like the ones exposed by the QR keyring and consumers will be able to access those methods via the method withKeyring.
@Gudahtt
Copy link
Member

Gudahtt commented May 30, 2024

Related: MetaMask/metamask-mobile#9748

@mikesposito
Copy link
Member

^ See this comment for details: #3786 (comment)

This was referenced Jan 15, 2025
Open
Open
@desi
Copy link
Contributor

desi commented Jan 27, 2025

Blocked by: MetaMask/accounts#144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@desi @Gudahtt @gantunesr @mikesposito