Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bugs in Footer and Navbar.jsx #368

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Bugs in Footer and Navbar.jsx #368

wants to merge 3 commits into from

Conversation

Kiran-pande-30
Copy link
Contributor

@Kiran-pande-30 Kiran-pande-30 commented Jul 30, 2024 •
edited
Loading

Related Issue

Fixes #356

Description

  1. Spelling of "Quick Links" and "Business hours"
  2. Added Item in NavMenu
    image
    This issue is solved.
  3. Three progress bars in the navbar
    I have removed the middle and bottom ones, the one on top is just great.
    image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024

@Kiran-pande-30 is attempting to deploy a commit to the My Team Team on Vercel.

A member of the Team first needs to authorize it.

@Kiran-pande-30
Update Footer.jsx
85d13c6 
The Quick and business were fixed
@Kiran-pande-30
Copy link
Contributor Author

@Agarwalvidu please review PR

@Khushi-Pushkar
Copy link
Contributor

Khushi-Pushkar commented Jul 31, 2024 •
edited
Loading

Hey @Kiran-pande-30 . I've already added the navbar items and included the login . To avoid any conflicts, could you please remove that portion? Thank you!

@Kiran-pande-30
Copy link
Contributor Author

Hey @Kiran-pande-30 . I've already added the navbar items and included the login . To avoid any conflicts, could you please remove that portion? Thank you!

Hello @Khushi-Pushkar i am happy to see the issue been resolved, I should also get something, It has taken some of my time too.

@Khushi-Pushkar
Copy link
Contributor

@Agarwalvidu and @everly-gif could you help us out with this?

@everly-gif
Copy link
Collaborator

@Khushi-Pushkar your PR can stay as it included routing for the login page. @Kiran-pande-30 your PR can stay as well. However if conflicts arises while merging you all need to remove them before merging.

But however in the bugs reported @Kiran-pande-30 you never specifically claimed the three progress bar issue. Which actually another contributor has worked upon. I would suggest you remove that part. All of you have worked on different aspects of the navbar issues and is valid. Overlapping will be there it's fine.

@Kiran-pande-30
Copy link
Contributor Author

Hello, @everly-gif I noticed the three progress bars while working on this issue. I will remove it as i never mentioned that i am solving that particular issue.

@everly-gif everly-gif self-requested a review August 6, 2024 16:41
@Mansi168
Copy link
Owner

Mansi168 commented Aug 9, 2024

plz resolve conflicts
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everly-gif everly-gif everly-gif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Minor Issues in Footer.jsx and Navbar.jsx
4 participants
@Kiran-pande-30 @Khushi-Pushkar @everly-gif @Mansi168