Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested batch_arg_name in BatchSizeFinder/Tuner.scale_batch_size() #20560

Open
ibro45 opened this issue Jan 23, 2025 · 0 comments
Open

Allow nested batch_arg_name in BatchSizeFinder/Tuner.scale_batch_size() #20560

ibro45 opened this issue Jan 23, 2025 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@ibro45
Copy link

ibro45 commented Jan 23, 2025 •
edited by github-actions bot
Loading

Description & Motivation

Hi,

Would it be possible to allow dot-notation in, for example, tuner.scale_batch_size(model, batch_arg_name="dataloaders.train.batch_size")?

Perhaps some other features would benefit from this. It should be simple to achieve that through lightning_hasattr and lightning_getattr.

Pitch

No response

Alternatives

No response

Additional context

No response

cc @lantiga @Borda
@ibro45 ibro45 added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ibro45