PHP 8.4 support (#89)

* PHP 8.4 support * Should fix static analysis
Laragear · Jan 29, 2025 · ee1d47b · ee1d47b
1 parent 1a8920b
commit ee1d47b
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -12,3 +12,4 @@
 /.editorconfig      export-ignore
 /.styleci.yml       export-ignore
 /composer.lock      export-ignore
+/phpstan.neon       export-ignore
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -57,6 +57,7 @@ jobs:
           - 8.1
           - 8.2
           - 8.3
+          - 8.4
         laravel-constraint:
           - 10.*
           - 11.*

diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,3 @@
+parameters:
+    ignoreErrors:
+        - '#Trait Laragear\\TwoFactor\\TwoFactorAuthentication is used zero times and is not analysed\.#'
diff --git a/src/Models/TwoFactorAuthentication.php b/src/Models/TwoFactorAuthentication.php
@@ -37,7 +37,7 @@
  * @property null|\Illuminate\Support\Carbon|\DateTime $updated_at
  * @property null|\Illuminate\Support\Carbon|\DateTime $created_at
  *
- * @method static \Database\Factories\Laragear\TwoFactor\TwoFactorAuthenticationFactory<static> factory($count = null, $state = [])
+ * @method static \Database\Factories\Laragear\TwoFactor\TwoFactorAuthenticationFactory factory($count = null, $state = [])
  */
 class TwoFactorAuthentication extends Model implements TwoFactorTotp
 {

diff --git a/src/TwoFactorServiceProvider.php b/src/TwoFactorServiceProvider.php
@@ -81,7 +81,7 @@ protected function publishFiles(): void
      */
     protected function publishMigrations(): void
     {
-        if (method_exists($this, 'publishesMigrations')) {
+        if (method_exists($this, 'publishesMigrations')) { // @phpstan-ignore-line
             $this->publishesMigrations([static::MIGRATIONS => $this->app->databasePath('migrations')], 'migrations');
 
             return;
-Original file line number
+Diff line change
@@ Expand Up / @@ -57,6 +57,7 @@ jobs: @@
               - 8.1
               - 8.2
               - 8.3
+              - 8.4
             laravel-constraint:
               - 10.*
               - 11.*
@@ Expand Down @@