Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonarcloud on external PR's #38

Open
Apfelwurm opened this issue May 1, 2022 · 0 comments
Open

sonarcloud on external PR's #38

Apfelwurm opened this issue May 1, 2022 · 0 comments
Labels
ci/cd discussion needed this issue requieres team discussion

Comments

@Apfelwurm
Copy link
Member

becuase of github security concept the sonarcloud scanning does not work with external pull requests and thats okay, because the tests are running code which is provided by the pr and could expose secrets.

we have to do one of those 3 things:

  • implement https://github.com/imjohnbo/ok-to-test so a comment with /ok-to-test sha= is required to run the testing
  • use the pull_request_target with type labled to run the test and lable each external pr with a lable
  • skip the sonarcloud test if no login is available which would disable the sonarcloud scan for external PRs, which is not good.
@Apfelwurm Apfelwurm added ci/cd discussion needed this issue requieres team discussion labels May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd discussion needed this issue requieres team discussion
Projects
None yet
Development

No branches or pull requests

1 participant