Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU Energy APIs and support for NVIDIA and AMD GPUs #559

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Jun 26, 2024

Description

Extend the new energy API from v0.8 to include GPU energy on NVIDIA and AMD GPUs.

6/26: This is WIP and won't compile/work just yet.

To Do 6/27:

  • We're reporting deltas in the energy reporting API (CPU only) and the first call to GPU energy needs to be 0; this PR needs to be edited to do this correctly. Getting raw value from vendor API, need to store this value as the offset, and a do a diff from the offset for all subsequent samples.
  • Clean out the commented code from variorum.c
  • Add AMD Rocm support rsmi_dev_energy_count_get()

Fixes #532.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

  • Lassen: GPU-only
  • Lassen: CPU-only
  • Lassen: CPU+GPU
  • Corona: GPU-only
  • Tioga: GPU-only
  • Tioga: CPU+GPU (blocked due to the HSMP module issue, will be tested later.)

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

@tpatki tpatki changed the title Add GPU Energy APIs Add GPU Energy APIs and support for NVIDIA and AMD GPUs Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for print and JSON APIs for GPU energy values
2 participants