Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type in variable declarations #520

Open
tpatki opened this issue Mar 4, 2024 · 0 comments
Open

Fix type in variable declarations #520

tpatki opened this issue Mar 4, 2024 · 0 comments

Comments

@tpatki
Copy link
Member

tpatki commented Mar 4, 2024

In many places in Variorum, I see declarations made as unsigned var, without the datatype being explicitly specified.
This defaults to unsigned int , and is functionally correct (unsigned is a datatype), but is not considered good engineering practice, esp because we're not consistent with its usage. As part of cleanup, I'd like to change these from unsigned to unsigned int.

See here as some examples:

void variorum_get_topology(
unsigned *nsockets,
unsigned *ncores,
unsigned *nthreads,

unsigned i;
char hostname[1024];
unsigned nthreads;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant