From b377fed5217e7eb80fe7ad00c33114ca0ee61bf9 Mon Sep 17 00:00:00 2001 From: David Weber Date: Mon, 13 Nov 2023 12:59:02 +0100 Subject: [PATCH] fix(serviceMonitor) set 30s as default interval the default interval should be 30s to support the rate of 1m of the official Kong Grafana dashboard --- charts/kong/CHANGELOG.md | 7 +++++++ charts/kong/templates/servicemonitor.yaml | 4 ++++ 2 files changed, 11 insertions(+) diff --git a/charts/kong/CHANGELOG.md b/charts/kong/CHANGELOG.md index 47ff4b7db..776439593 100644 --- a/charts/kong/CHANGELOG.md +++ b/charts/kong/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## Unreleased + +### Fixed + +* The default interval should be 30s to support the rate of 1m of the official [Kong Grafana dashboard](https://grafana.com/grafana/dashboards/7424-kong-official/). + [#941](https://github.com/Kong/charts/pull/941) + ## 2.31.0 ### Improvements diff --git a/charts/kong/templates/servicemonitor.yaml b/charts/kong/templates/servicemonitor.yaml index db3dfbf35..e7fb672b2 100644 --- a/charts/kong/templates/servicemonitor.yaml +++ b/charts/kong/templates/servicemonitor.yaml @@ -17,6 +17,8 @@ spec: scheme: http {{- if .Values.serviceMonitor.interval }} interval: {{ .Values.serviceMonitor.interval }} + {{- else }} + interval: 30s {{- end }} {{- if .Values.serviceMonitor.honorLabels }} honorLabels: true @@ -29,6 +31,8 @@ spec: scheme: http {{- if .Values.serviceMonitor.interval }} interval: {{ .Values.serviceMonitor.interval }} + {{- else }} + interval: 30s {{- end }} {{- if .Values.serviceMonitor.honorLabels }} honorLabels: true