Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add options to get variables function #43

Closed
10 tasks done
CalvinWilkinson opened this issue Feb 23, 2024 · 0 comments · Fixed by #98
Closed
10 tasks done

🚧Add options to get variables function #43

CalvinWilkinson opened this issue Feb 23, 2024 · 0 comments · Fixed by #98
Assignees
Labels
💎enhancement An improvement on something medium-priority Medium Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Feb 23, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Add some options to the getVariables() function in the RepoClient and OrgClient class. These options will be used to signify how to trim the variable values.

Add the following options:

  1. Add the ability to trim spaces, \n, and \r characters from the beginning and end of the variable values.
  2. Add the ability to return all of the values in uppercase or lowercase

Each option should represent a different trimming behavior.

Here are the trimming behaviors:

/**
 * Represents different carriage return and/or line feed trimming types.
 */
export type TrimType = 
    "TrimStart" |
    "TrimEnd" |
    "TrimBoth" |
    "None";

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.

Preview Give feedback

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added the ✨new-feature New feature that does not exist label Feb 23, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.9 milestone Feb 23, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Feb 23, 2024
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Feb 23, 2024
@CalvinWilkinson CalvinWilkinson added the medium-priority Medium Priority label Feb 23, 2024
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🤙🏼PR Changes Requested in KD-Team Oct 15, 2024
@CalvinWilkinson CalvinWilkinson moved this from 🤙🏼PR Changes Requested to 🏗️In Development in KD-Team Oct 15, 2024
@CalvinWilkinson CalvinWilkinson added the preview Done while in preview label Oct 15, 2024
CalvinWilkinson added a commit that referenced this issue Oct 15, 2024
@CalvinWilkinson CalvinWilkinson added 💎enhancement An improvement on something and removed ✨new-feature New feature that does not exist labels Oct 15, 2024
CalvinWilkinson added a commit that referenced this issue Oct 15, 2024
* Start work for issue #43

* enhance: create type to represent different transformations

* enhance: created new type for get variables function

* enhance: add ability to transform the variable values in the repo client

* enhance: add ability to transform variable values in release client

* docs: remove func param docs

* chore: added types to mod file
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎enhancement An improvement on something medium-priority Medium Priority preview Done while in preview
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant