Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add remove label function to clients #104

Open
3 of 6 tasks
CalvinWilkinson opened this issue Oct 31, 2024 · 0 comments
Open
3 of 6 tasks

🚧Add remove label function to clients #104

CalvinWilkinson opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
high-priority High Priority ✨new-feature New feature that does not exist preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 31, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Add a remove label function with the name removeLabel() to the IssueClient and PullRequestClient class.

This function will use the GitHub REST API Endpoint to remove the label from the issue.

Note

This endpoint removes labels from issues and pull requests.
For the IssueClient, we need to check if the label and issue number coming into the function exist before we remove the label.
For the PullRequestClient, we need to check if the label and pr number coming into the function exist before we remove the label.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.

Preview Give feedback

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview ✨new-feature New feature that does not exist labels Oct 31, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.15 milestone Oct 31, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Oct 31, 2024
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Oct 31, 2024
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority High Priority ✨new-feature New feature that does not exist preview Done while in preview
Projects
Status: 🏗️In Development
Development

No branches or pull requests

1 participant