Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Fix app service path resolution #1081

Open
3 of 7 tasks
CalvinWilkinson opened this issue Jan 21, 2025 · 0 comments · May be fixed by #1082
Open
3 of 7 tasks

🚧Fix app service path resolution #1081

CalvinWilkinson opened this issue Jan 21, 2025 · 0 comments · May be fixed by #1082
Assignees
Labels
🐛bug Something isn't working high-priority High Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Jan 21, 2025

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Improve the directory path resolution in the AppService class.

This will involve changing the logic of the AppDirectory property to use the AppContext.BaseDirectory API instead of using the Assembly.GetExecutingAssembly() API.

The reason for this is that when using the Assembly.GetExecutingAssembly().Location API, the value is empty when publishing as a single file. This is due to where the contained binaries and dotnet files are managed and extracted to on the first execution of a single file published application.

With this change, this means content directory path resolution will work correctly when publishing as a single file.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.

Preview Give feedback

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview 🐛bug Something isn't working labels Jan 21, 2025
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.41 milestone Jan 21, 2025
@CalvinWilkinson CalvinWilkinson self-assigned this Jan 21, 2025
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Jan 21, 2025
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Jan 21, 2025
@CalvinWilkinson CalvinWilkinson changed the title 🚧Improve app service path resolution 🚧Fix app service path resolution Jan 22, 2025
CalvinWilkinson added a commit that referenced this issue Jan 22, 2025
@CalvinWilkinson CalvinWilkinson linked a pull request Jan 22, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working high-priority High Priority preview Done while in preview
Projects
Status: 🏗️In Development
Development

Successfully merging a pull request may close this issue.

1 participant