You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have updated the title without removing the 🚧 emoji.
Description
Improve the directory path resolution in the AppService class.
This will involve changing the logic of the AppDirectory property to use the AppContext.BaseDirectory API instead of using the Assembly.GetExecutingAssembly() API.
The reason for this is that when using the Assembly.GetExecutingAssembly().Location API, the value is empty when publishing as a single file. This is due to where the contained binaries and dotnet files are managed and extracted to on the first execution of a single file published application.
With this change, this means content directory path resolution will work correctly when publishing as a single file.
Acceptance Criteria
The content you are editing has changed. Please copy your edits and refresh the page.
The items to complete to satisfy the Definition of Done.
Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!
💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.
Change Type Labels
Change Type
Label
Bug Fixes
🐛bug
Breaking Changes
🧨breaking-changes
New Feature
✨new-feature
CICD Changes
♻️cicd
Config Changes
⚙️config
Performance Improvements
🏎️performance
Code Doc Changes
🗒️documentation/code
Product Doc Changes
📝documentation/product
Priority Type Labels
Priority Type
Label
Low Priority
low priority
Medium Priority
medium priority
High Priority
high priority
Code of Conduct
I agree to follow this project's Code of Conduct.
The text was updated successfully, but these errors were encountered:
Complete The Item Below
Description
Improve the directory path resolution in the
AppService
class.This will involve changing the logic of the
AppDirectory
property to use theAppContext.BaseDirectory
API instead of using theAssembly.GetExecutingAssembly()
API.The reason for this is that when using the
Assembly.GetExecutingAssembly().Location
API, the value is empty when publishing as a single file. This is due to where the contained binaries and dotnet files are managed and extracted to on the first execution of a single file published application.With this change, this means content directory path resolution will work correctly when publishing as a single file.
Acceptance Criteria
The items to complete to satisfy the Definition of Done.
ToDo Items
The items to complete to satisfy the Definition of Done.
Issue Dependencies
No response
Related Work
No response
Additional Information:
Unit Tests
Reasons for local unit test execution:
💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.
Change Type Labels
🐛bug
🧨breaking-changes
✨new-feature
♻️cicd
⚙️config
🏎️performance
🗒️documentation/code
📝documentation/product
Priority Type Labels
low priority
medium priority
high priority
Code of Conduct
The text was updated successfully, but these errors were encountered: