Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Setting BufferType.Stream for sample causes it to glitch, repeating it partially #361

Closed
3 tasks done
NinovanderMark opened this issue Sep 1, 2024 · 0 comments · Fixed by #387
Closed
3 tasks done
Assignees
Labels
🐛bug Something isn't working high-priority High Priority preview Done while in preview

Comments

@NinovanderMark
Copy link

NinovanderMark commented Sep 1, 2024

Complete The Items Below

  • I have updated the title without removing the 🐛 emoji.
  • I searched whether or not an issue already exists for the bug I encountered.

Current Behavior

When playing the attached sample and setting the BufferType to BufferType.Stream the sample playback is glitched, as part of the end of the sample is repeated. This does not occur when using BufferType.Full

Expected Behavior

The sound sample should be played back normally regardless of the BufferType used.

Steps To Reproduce

The code to play back the sample is as follows:

var crunch = new Audio(Path.Combine("audio", "crunch.ogg"), BufferType.Stream);
crunch.Play();

Operating System(s)

Windows

OS Version

10.0.19045

Anything Else

crunch.zip

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

Preview Give feedback

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Sep 1, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Feb 5, 2025
@CalvinWilkinson CalvinWilkinson added 🐛bug Something isn't working high-priority High Priority preview Done while in preview labels Feb 5, 2025
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Feb 5, 2025
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.21 milestone Feb 5, 2025
CalvinWilkinson added a commit that referenced this issue Feb 5, 2025
CalvinWilkinson added a commit that referenced this issue Feb 5, 2025
…it partially (#387)

* Start work for issue #361

* fix: fix bug with crunch sound at the end of small ogg audio files

* fix: fix bug with crunch sound at the end of small mp3 audio files

* refactor: remove duplicate code

* refactor: improve code readability

* chore: create thin wrapper around vorbis reader API

* chore: refactor ogg decoder to use wrapper

* chore: add vorbis wrapper type to IoC container

* test: create test extension for generating range of float values

* test: update ogg decoder tests

* chore: create thin wrapper for the mp3 stream api

* test: create method extension to easily create an array of bytes

* chore: refactor mp3 audio decoder to use thin wrapper

* chore: update audio decoder factory

* test: update mp3 audio decoder tests

* refactor: move task wait loop to task service

* test: add test to stream buffer

* chore: add mp3 stream wrapper type to IoC container

* ide: add word to dictionary
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working high-priority High Priority preview Done while in preview
Projects
Status: ✅Done
2 participants