UAV kills do not count towards 'stats_xyz_by_players' scores

[ross1296]

Bug report

Basic Information

Mission version:
v0.96.7a

Map used:
Altis

Mods used:
None

Dedicated or local game:
Tested on both

Source of the mission file (URL):
Taken directly from your master branch and ran build.bat

Individual Things

Did you edit anything within the mission files?
Yes

If yes, what did you edit exactly?
I added a silentHint for debugging purposes in kill_manager.sqf

Short Issue Description

Killing civilians, opfor, vehicles etc with a UAV doesn't count towards the scores. E.g. stats_opfor_killed_by_players or stats_civilians_killed_by_players.

Why? Because isPlayer _killer returns false when the kill is the result of a UAV strike. Instead isPlayer _instigator is true, as _instigator is the person who pulled the trigger -- useful for UAVs. https://community.bistudio.com/wiki/Arma_3:_Event_Handlers#MPKilled

Here is my debug I produced in the mission:

Vehicle kill using a launcher, outside of a vehicle: https://media.discordapp.net/attachments/996103017243885680/1087792212789710978/image.png

Vehicle kill using a UAV:
https://media.discordapp.net/attachments/996103017243885680/1087792435716952084/image.png

Expected Behaviour

UAV kills should count towards the score

Steps to Reproduce the Issue

1. Hop into the mission and check one of the scores. E.g. stats_civilians_killed_by_players
2. Grab a UAV and a UAV Terminal and fly it somewhere with a civilian
3. Kill one or two
4. Check score again

Here's the debug code I used for the hintSilent

params ["_unit", "_killer", "_instigator"];

hintSilent parseText format["Player: %1<br/>Killer: %2<br/>Instigator: %3<br/>Killed: %4<br/>isPlayer Killer: %5<br/>isPlayer Instigator: %6", (name player), (name _killer), (name _instigator), (name _unit), (isPlayer _killer), (isPlayer _instigator)];

Screenshots, Serverlog or any other helpful Information

Vehicle kill using a launcher, outside of a vehicle: https://media.discordapp.net/attachments/996103017243885680/1087792212789710978/image.png

Vehicle kill using a UAV:
https://media.discordapp.net/attachments/996103017243885680/1087792435716952084/image.png