From 34cd111592a2e38a5c003a4c7ae94e6c4407b258 Mon Sep 17 00:00:00 2001 From: Paul Hebble Date: Wed, 27 Nov 2024 10:43:16 -0600 Subject: [PATCH 1/3] Markdown syntax --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b006e08..85fefab 100644 --- a/README.md +++ b/README.md @@ -119,7 +119,7 @@ jobs: ## See also -Validate your KSP-AVC .version files with https://github.com/DasSkelett/AVC-VersionFileValidator ! +Validate your KSP-AVC .version files with ! ## Contributions From ed4747add94cf41a799312e231f26f487e911e8b Mon Sep 17 00:00:00 2001 From: Paul Hebble Date: Wed, 27 Nov 2024 10:42:45 -0600 Subject: [PATCH 2/3] Skip install step when metadata is unchanged --- ckan_meta_tester/ckan_meta_tester.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ckan_meta_tester/ckan_meta_tester.py b/ckan_meta_tester/ckan_meta_tester.py index 11ad576..5d02c1d 100644 --- a/ckan_meta_tester/ckan_meta_tester.py +++ b/ckan_meta_tester/ckan_meta_tester.py @@ -189,6 +189,10 @@ def install_ckan(self, file: Path, orig_file: Path, pr_body: Optional[str], meta if meta_repo is not None: diff = ckan.find_diff(meta_repo) if diff is not None: + if len(diff) == 0: + print(f'::notice file={orig_file}::Diff empty for {ckan.name} {ckan.version}, skipping install', + flush=True) + return True with LogGroup(f'Diffing {ckan.name} {ckan.version}'): print(diff, end='', flush=True) with LogGroup(f'Installing {ckan.name} {ckan.version}'): From f586186fd5a4ad9e20661c0412ec31167e081114 Mon Sep 17 00:00:00 2001 From: Paul Hebble Date: Wed, 27 Nov 2024 11:09:06 -0600 Subject: [PATCH 3/3] Try to bypass linter error --- tests/dummy_game_instance.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/dummy_game_instance.py b/tests/dummy_game_instance.py index 004da15..c944379 100644 --- a/tests/dummy_game_instance.py +++ b/tests/dummy_game_instance.py @@ -2,7 +2,6 @@ import unittest.util from unittest import TestCase from unittest.mock import Mock, patch, call -from tempfile import TemporaryDirectory, TemporaryFile from ckan_meta_tester.game import Game from ckan_meta_tester.game_version import GameVersion @@ -26,7 +25,7 @@ def test_dummy_game_instance_calls(self, mocked_run: Mock) -> None: # Arrange - unittest.util._MAX_LENGTH=999999999 # :snake: + unittest.util._MAX_LENGTH=999999999 # type: ignore # pylint: disable=protected-access # Act with DummyGameInstance(