Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ability to suppress missing file checks for files auto-deleted by mods #4204

Closed
1 task done
kretze opened this issue Sep 27, 2024 · 7 comments · Fixed by #4213
Closed
1 task done

[Feature] Ability to suppress missing file checks for files auto-deleted by mods #4204

kretze opened this issue Sep 27, 2024 · 7 comments · Fixed by #4213
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI

Comments

@kretze
Copy link

kretze commented Sep 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Operating System

Windows 10

CKAN Version

1.35.0

Games

KSP 1

Game Version

1.12.5

Did you make any manual changes to your game folder (i.e., not via CKAN)?

No response

Describe the bug

CKAN now constantly checks the installed contents of the mods in the gamedata folder.
FAR has a file that is deleted after it has been imported once. As a result, CKAN constantly reports that the FAR file is missing and wants to install an update.

image

image

Steps to reproduce

install FAR
start KSP and exit
start CKAN again

Relevant log output

No response

@kretze kretze changed the title [Bug]: CKAN wants to reinstall/update FAR every time KSP is closed [Bug]: CKAN wants to reinstall/update FAR every time KSP after is closed Sep 28, 2024
@kretze kretze changed the title [Bug]: CKAN wants to reinstall/update FAR every time KSP after is closed [Bug]: CKAN wants to reinstall/update FAR every time after KSP is closed Sep 28, 2024
@kretze
Copy link
Author

kretze commented Sep 28, 2024

same as #4205

@HebaruSan
Copy link
Member

same as #4205

Slightly different use case, though. In that one, the user has explicitly chosen to delete certain files, whereas with yours the mod itself is deleting one of its own files. At this point my expectation is that these would require different solutions.

@HebaruSan HebaruSan changed the title [Bug]: CKAN wants to reinstall/update FAR every time after KSP is closed [Feature] Ability to suppress missing file checks for files auto-deleted by mods Sep 29, 2024
@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN labels Sep 29, 2024
@HebaruSan
Copy link
Member

This suggestion from the other issue fits better here:

A label option comes to mind for this. With a type "no compare" or "no file check".
Just like it's currently done with "don't upgrade".

image

@kretze
Copy link
Author

kretze commented Sep 29, 2024

Is this related to the filter extension in the content tab? That didn't happen before.
Commit: Apply filters to Contents tab, red highlight if missing

Therefore this was not reported in V1.34.4 and earlier, correct?

@HebaruSan
Copy link
Member

Hi @kretze, right, the missing file behavior is new in v1.35.0, see #4067.

@Delta-86
Copy link

To add to this, this also causes issues with Zero MiniAVC, as any mods it prunes then state that they need to be updated.

@HebaruSan
Copy link
Member

@Delta-86, yes, it's a good idea to uninstall ZeroMiniAVC anyway, see KSP-CKAN/NetKAN#10230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants