Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant return in R2 #149

Closed
MaxenceGollier opened this issue Sep 9, 2024 · 1 comment
Closed

Redundant return in R2 #149

MaxenceGollier opened this issue Sep 9, 2024 · 1 comment

Comments

@MaxenceGollier
Copy link
Contributor

There is a return that should not be there in [R2.jl].
(https://github.com/JuliaSmoothOptimizers/RegularizedOptimization.jl/blob/c37c5126660ce90ad8145785343b78ebe7fa7b7d/src/R2_alg.jl)

return R2(
reg_nlp,
x = x0,
atol = options.ϵa,
rtol = options.ϵr,
neg_tol = options.neg_tol,
verbose = options.verbose,
max_iter = options.maxIter,
max_time = options.maxTime,
σmin = options.σmin,
η1 = options.η1,
η2 = options.η2,
ν = options.ν,
γ = options.γ,
)
return stats

This does not change anything to the results because we do want to return R2(...).
I am opening a PR to remove it.

@MaxenceGollier
Copy link
Contributor Author

Solved in #150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant